Thanks Francis for the pointer, it works!
Then I guess the right url should be:
https://sonarcloud.io/project/overview?id=apache_calcite
This one works for me.
Francis Chuang 于2023年1月16日周一 04:46写道：
> Hey Benchao,
>
> I also see that issue when trying to log in via
> https://sonarcloud.io/projec
Hey Benchao,
I also see that issue when trying to log in via
https://sonarcloud.io/project/roles?id=apache_calcite. The solution is
to log in here: https://sonarcloud.io/login, go to the Apache
organization and then go to the calcite project.
Francis
On 16/01/2023 12:36 am, Benchao Li wrote
When I open this url[1], it tells me that "You are not authorized to access
this page". Is this expected?
(I'm using my Github account)
[1] https://sonarcloud.io/project/roles?id=apache_calcite
Alessandro Solimando 于2023年1月13日周五 18:51写道：
> Thank you Stamatis for working on this, I see no need t
Thank you Stamatis for working on this, I see no need to remove the Sonar
analysis now that the quality gate is off.
In the meantime, since all committers have write privilege in Sonar,
whoever is interested can help fine-tuning it to fit our needs (for
instance disabling rules like the code smell
I logged CALCITE-5474 [1] to disable the failures in Sonar checks
allowing everything to appear as green.
Sonar annotations are still going to appear under the PR after
CALCITE-5474; if the intention is to remove also these indications let
me know and I will log another ticket.
Best,
Stamatis
[1
Now a build 'failed' with 7 'code smells'.
Duplicating a string literal in a test was deemed as 'critical code
smell'. For heaven's sake.
https://sonarcloud.io/project/issues?resolved=false&severities=CRITICAL&types=CODE_SMELL&pullRequest=2942&id=apache_calcite
Adding '@Deprecated' without al
Hi everyone,
I agree with Julian that we should be open to see what value Sonar brings
with the current setup, but for a true accounting we need many more data
points, two examples are just not enough.
In my experience I see reviewers asking contributors to fix real issues
that Sonarlint plugin ca
The instanceof case was complicated. The code that Kevin wrote was good, and
appropriate, and when Sonar blocked it Stamatis was able to find an alternative
formulation, which existed because, by luck, the JSR had deprecated an
exception class but not its base class. I spent 30 minutes reviewing
Hello,
First of all, thanks Stamatis for implementing this, I think it is
something good for the project.
In the beginning things might be a bit complicated (as always) and we might
need some adjustments / clarifications, but I hope that in the long run
we'll see this as a useful feature.
Regardi
Thanks for the feedback!
I would like to stretch the fact that at this point it is at the discretion
of the reviewer/committer to enforce or ignore the information provided by
Sonar.
Sonar, as other similar systems, has limitations thus there are always
going to be false positives. The rules/chec
I see two false positives so far:
* The message on be7135cf "58.1% Coverage on New Code (is less than 80%)"
* The bug on PR 2942 "Use an "instanceof" comparison instead"
Has Sonarcube had any true positives yet?
Vladimir used to hate when I was skeptical of changes to the build
system. But I ha
Thanks for implementing this, Stamatis! Having code quality metrics on
our repos is a huge win.
Francis
On 10/01/2023 4:22 am, Stamatis Zampetakis wrote:
I just merged the CALCITE-5427 [1] enabling Sonarcloud analysis for Calcite
main branch and new PRs.
I have left the default Sonar quality
I just merged the CALCITE-5427 [1] enabling Sonarcloud analysis for Calcite
main branch and new PRs.
I have left the default Sonar quality gates active so you may start seeing
Sonar reporting errors in various cases.
If you encounter problems or you would like things to work differently
please cr
The integration is advancing well and I am hoping to merge the PR in the
coming days.
To avoid unpleasant surprises, I am planning to create a new remote branch
in the main calcite repo to test some things out. I will delete it as soon
as I am done with the tests.
Best.
Stamatis
On Wed, Dec 28, 2
Thanks Stamatis! I haven't used SonarCloud before, but in general I think
such tools can be quite useful.
--
Michael Mior
mm...@apache.org
On Sat, Dec 24, 2022 at 4:01 PM Stamatis Zampetakis
wrote:
> Since there were no objections, I just logged INFRA-24038 [1] and plan to
> move this forward.
Since there were no objections, I just logged INFRA-24038 [1] and plan to
move this forward.
Let me know if you have questions or concerns regarding the adoption of
SonarCloud.
Best,
Stamatis
[1] https://issues.apache.org/jira/browse/INFRA-24038
On Sat, Dec 10, 2022 at 11:32 AM Benchao Li wrot
Thanks Stamatis for bringing this up.
I haven't used Sonar yet, but thanks for the demo[1] you provided, it looks
really interesting. I think it's worth a try for Calcite.
[1] https://github.com/zabetak/calcite/pull/9
Alessandro Solimando 于2022年12月10日周六
02:54写道：
> Hi all,
> thanks Stamatis for
Hi all,
thanks Stamatis for the proposal and the work, I am a huge fan of Sonar and
I really miss it on Calcite, so a big +1 from me on this.
In Hive so far we have received good feedback, so I hope it will be
welcomed here too.
Best regards,
Alessandro
On Fri, 9 Dec 2022 at 19:02, Stamatis Zamp
Hi all,
I just logged CALCITE-5427 [1] for introducing code quality & coverage
metrics in Calcite CI.
I added some motivation and examples under the ticket so please have a look
and let me know what you think.
If there are no objections, I will follow-up with INFRA to set things up
for the offic
19 matches
Mail list logo
