[DISCUSS] Syntax upgrade about Session Window Table Function

Hi community, I'm now working on CALCITE-4337 [1] which aims to support PARTITION BY clause for table function argument. I've submitted a pull request [2], thanks @Danny very much for review. There ar

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Regarding changes to the syntax of the SESSION table function. I am open to this, even though it would be a breaking change. Can you give an example of a query before and after the syntax change? I would like to support the new PARTITIONED BY clause for table functions. I encourage you to make

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Hi Julian, Thanks for your feedback, the suggestion is very helpful. I've added the discussion content the CALCITE-4337 [1]. I would continue later discussion in the JIRA case. About an example of a query before and after the syntax change. I wou

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Thanks for the examples. The PARTITION BY syntax is a clear improvement for the SESSION function and I think we should do it, even though it is breaking. I’ll make further comments against https://issues.apache.org/jira/browse/CALCITE-4337 .

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Btw, the table argument, according to the sql standard, must be in parentheses, like this: SELECT * FROM TABLE(SESSION(TABLE(input_table), ... When doing a breaking change, we should also consider this. Viliam On Thu, 30 Sept 2021 at 18:11, Julian Hyde wrote: > Thanks for the examples. The PA

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Sorry for late reply because we were in a vocation holiday. @Julian > Thanks for the examples. The PARTITION BY syntax is a clear improvement > for the SESSION function and I think we should do it, even though it is > breaking. Thanks for great suggestion. I’ll make further comments against > h

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Hi Julian, Thanks very much for professional comments in CALCITE-4337. I have checked the SQL standard and some database vendors behavior on PTF in order to figure out your questions. I left the message in https://issues.apache.org/jira/browse/CALCITE-4337. Please correct me if I'm wrong. Thanks a

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Hi Julian, Viliam, Thanks for advises in CALCITE-4337 . Please have another look at CALCITE-4337 . If there is no objections, I would continue develop work based on discussion conclusion. Best w

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

Hi Julian, Thanks for responding in CALCITE-4337 . > I find this feature easier to understand via syntax. Therefore I propose > that we should implement this via changes to the DDL parser in the server > module, including parser changes in server