kgyrtkirk commented on issue #980: [CALCITE-2736] Update the ReduceExpressionsRule to better expose options URL: https://github.com/apache/calcite/pull/980#issuecomment-463647710 I think having something to help configure `ReduceExpressionRule` would be good; `ReductionOptions` could be a step in that direction; I've seen a case in which there would have been very good to have better control over what ReduceExpressionRule is doing. @jacques-n I think that using 3 booleans is not really future-proof; you can't tell from a blink of an eye what are those booleans are representing - and in case of a future addition of a new configurable feature; the addition of it would just break all callsites to the options. note: I'm not sure if there should be a public "DEFAULT_OPTIONS" or "DEFAULT_FILTER_OPTIONS" I think that api users should either use the instances like PROJECT_INSTANCE or let them configure there own - if they are about to create an instance they are probably already aware what they are doing...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
