Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Julian Hyde
Done. Let's continue the conversation at CALCITE-5503. On Fri, Jan 27, 2023 at 10:08 AM Moritz Mack wrote: > > Julian, I’ve created CALCITE-5503 as suggested. > > Would you be able to add me as a contributor in Jira and assign the ticket to > me. > I opened a PR with the test case you’ve asked

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
Julian, I’ve created CALCITE-5503 as suggested. Would you be able to add me as a contributor in Jira and assign the ticket to me. I opened a PR with the test case you’ve asked for and a rather trivial fix. https://github.com/apache/calcite/pull/3050 Thanks, Moritz On 27.01.23, 10:00, "Moritz

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
Thanks a lot, Julian. I’ll look into that the next few days. /Moritz On 25.01.23, 17:04, "Julian Hyde" wrote: It would seem a reasonable and useful enhancement if CheapestPlanReplacer did some memoization. If it sees the same RelNode twice it should emit the same result. I would be

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-25 Thread Julian Hyde
It would seem a reasonable and useful enhancement if CheapestPlanReplacer did some memoization. If it sees the same RelNode twice it should emit the same result. I would be conservative, and memoize based on identity of the RelNodes, not just equality. It would be useful if you could come up

[SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-25 Thread Moritz Mack
Dear Calcite Devs, I’m currently looking into an issue in the SQL extension [1] of Apache Beam and was hoping to find some advice here. Using a bunch of Calcite ConverterRules [2], we convert a RelNode tree into a tree of BeamRelNodes which is then used to build a Beam DAG. Pretty standard I