Re: [VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-12 Thread Vladimir Sitnikov
Josh>-0 I don't see this as a burden as you do, but don't feel strongly Here you go, sir: https://github.com/apache/calcite/pull/830/commits/73452b9d89f1677d1dcbe0d7d1c642bc9082b828#diff-977410f84ab14e4d3890bd28f221ed8dR359 I've no idea how come I named the class with "Programm" inside, however af

Re: [VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-11 Thread Julian Hyde
-0 I don’t think it’s worth getting into debates about coding style. > On Sep 10, 2018, at 1:12 PM, Josh Elser wrote: > > -0 I don't see this as a burden as you do, but don't feel strongly either way. > > On 9/10/18 4:49 AM, Vladimir Sitnikov wrote: >> Hi, >> Could we have a vote on coding sty

Re: [VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-10 Thread Josh Elser
-0 I don't see this as a burden as you do, but don't feel strongly either way. On 9/10/18 4:49 AM, Vladimir Sitnikov wrote: Hi, Could we have a vote on coding style regarding "// End File.java" in Calcite source files? "//End..." comments clutter Git history, they consume screen space, and the

Re: [VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-10 Thread Michael Mior
+0 I've never found these comments caused any problems for me but if the consensus is that it slows down things for others, I have nothing against removing them. -- Michael Mior mm...@apache.org Le lun. 10 sept. 2018 à 04:49, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> a écrit : > Hi, > >

Re: [VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-10 Thread Christian Beikov
+1 Am 10.09.2018 um 10:49 schrieb Vladimir Sitnikov: Hi, Could we have a vote on coding style regarding "// End File.java" in Calcite source files? "//End..." comments clutter Git history, they consume screen space, and they slow down the development by causing Checkstyle violations. Could we

[VOTE] [CALCITE-490] Remove "End File.java" comments from the end of files

2018-09-10 Thread Vladimir Sitnikov
Hi, Could we have a vote on coding style regarding "// End File.java" in Calcite source files? "//End..." comments clutter Git history, they consume screen space, and they slow down the development by causing Checkstyle violations. Could we vote on the style regarding "//End File.java" [ ] +1, r