Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-28 Thread Julian Hyde
> Andrei wrote: > > 1.32 history section is being added as a jekyll comment and is not visible > on the public site Oops, my bad. I didn’t notice the comment markers. I should have reviewed more carefully. I think it’s fine to leave it in. > Overall I'm inclined to create RC1 mainly because of i

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-28 Thread Andrei Sereda
I have started a separate thread for RC1. Among fixes that have been discussed previously, it also includes new Avatica version 1.22: CALCITE-5221 On Tue, Jul 26, 2022 at 6:33 PM Andrei Sereda wrote: > Hello, > > Thanks for the detailed feedback. > > Regarding differences between git and src re

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-26 Thread Andrei Sereda
Hello, Thanks for the detailed feedback. Regarding differences between git and src releases (empty folders reported by Stamatis) it is indeed a stale state of my branch. It is the main reason I'd like to make a clean (RC1) release candidate. Some answers to Julian's notes: > 1. It's strange tha

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-25 Thread Julian Hyde
Andrei, Thank you for being release manager! Downloaded, checked signatures & checksums, LICENSE, NOTICE, howto.md; compiled and ran tests using OpenJDK 18 and Gradle-7.4.2 on Ubuntu Linux. My vote is 0 (binding) due to the arrow and .mvn directories noted by Stamatis. I will change my vote to +1

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-25 Thread Ruben Q L
Thanks Andrei for being RM. - Checksum and signature: ok - Gradle test: ok - Calcite-based application test suite: ok - I confirm the diff issues already described by Stamatis, not sure if this should be a blocking problem or not. My vote is: 0 (binding) Best, Ruben On Mon, Jul 25, 2022 at 5:0

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-25 Thread Stamatis Zampetakis
Ubuntu 20.04.4 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.4.2 * Checked signatures and checksums OK * Went over release note OK (left some comments in the draft PR) * Built from git tag and run tests (./gradlew clean build) OK * Built from source artifacts and run unit tests + slow tests OK

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-24 Thread Francis Chuang
Thanks for being RM for this release, Andrei. My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Checked release notes on tag (https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md) - OK - Ran tests (gradle check) - OK - Spot checked Nexu

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-24 Thread Benchao Li
+1 (non-binding) - checked checksum and signatures: OK - checked NOTICE/LICENSE in source and jar: OK - build and test from source: OK - build javadoc: OK - checked with older guava versions(19.0): OK Besides, I would like to bring up CALCITE-5092. I checked our release process, and found that we

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-24 Thread Vova Vysotskyi
Hi everyone, I have verified signatures for distribution, built it, run all unit tests, and no issues are found. Also, I have checked the new Calcite version with Apache Drill, and it works fine, all Drill unit tests also pass. +1 (binding) Kind regards, Volodymyr Vysotskyi On 2022/07/23 03:

Re: [VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-23 Thread Alessandro Solimando
Hello everyone, thanks a lot Andrei for all the work behind this release, very much appreciated. My vote is +1 (non-binding) but I would like to highlight the differences I noticed with respect to the tag when checked out from the git repo, it does not look major but I don't remember seeing a simi

[VOTE] Release Apache Calcite 1.31.0 (release candidate 0)

2022-07-22 Thread Andrei Sereda
Hi all, I have created a build for Apache Calcite 1.31.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.31.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox