[VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-22 Thread Sergey Nuyanzin
Hi all, I have created a build for Apache Calcite 1.37.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md The commit to be voted upon: https://gitbox

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-22 Thread Francis Chuang
Thanks for being RM for this release, Sergey! My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Diffed source release and git repository - OK - Checked release notes on tag (https://github.com/apache/calcite/blob/calcite-1.37.0-rc0/site/_docs/history.md) - OK - C

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-23 Thread Ruben Q L
Thanks Sergey for preparing this release. Just a minor clarification: the email subject says "release candidate 1", but we are actually voting rc0. - Release notes: ok (with some minor comments that I have left in the PR) - Checksum: ok - Signature: ok - Diff source release and git repository: ok

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Benchao Li
+1 (binding) - Checked signature and checksum (OK) - Checked LICENSE and Copyright year (OK) - Checked there are no unexpected binary files (OK) - Build and test from source (testContributorsFileIsSorted and testMailmapFile in LintTest failed due to not in git repo) - Reviewed release note, left s

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Stamatis Zampetakis
Ubuntu 20.04.6 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 7.6.1 * Checked signatures and checksums OK * Checked diff between repo and artifacts OK * Went over release note OK (Left comments in the PR) * Checked README, NOTICE, LICENSE OK * All source files have ASF headers OK (raised [1] for t

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Sergey Nuyanzin
Thanks Stamatis for signalling this issue I think we need to put Blocker priority on this jira issue (CALCITE-6385[1]) if we consider it as a no go for the release (please correct me if I'm wrong) [1] https://issues.apache.org/jira/browse/CALCITE-6385 On Wed, Apr 24, 2024 at 11:59 AM Stamatis Za

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Ruben Q L
I think Stamatis is right. We should cancel this vote, fix CALCITE-6385 and produce a new RC. Best, Ruben On Wed, Apr 24, 2024 at 12:50 PM Sergey Nuyanzin wrote: > Thanks Stamatis for signalling this issue > > I think we need to put Blocker priority on this jira issue > (CALCITE-6385[1]) if we

Re: [VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Sergey Nuyanzin
Yes, agree, CALCITE-6385 is a blocker. I'll cancel the vote. Thanks for finding this, Stamatis, thanks Ruben for clarification, and thanks for all who took the time to vote. On Wed, Apr 24, 2024 at 2:01 PM Ruben Q L wrote: > I think Stamatis is right. We should cancel this vote, fix CALCITE-638

[CANCEL][VOTE] Release Apache Calcite 1.37.0 (release candidate 1)

2024-04-24 Thread Sergey Nuyanzin
Cancel this thread, due to CALCITE-6385[1] issue in the build. Thanks to Stamatis for highlighting this. Will start another vote once the issue will be fixed and merged. [1] https://issues.apache.org/jira/browse/CALCITE-6385 -- Best regards, Sergey