[VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-16 Thread Francis Chuang
Hi all, I have created a build for Apache Calcite Avatica 1.17.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/d56fcd004c68ca89c7e6aed2a86d46a9cb74f885/site/_docs/history.md The

Re: [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-18 Thread Julian Hyde
+1 Checked signatures, L&N, compiled and ran tests on Ubuntu (JDK 14, Guava 29.0-jre) and (JDK 8, Guava 14.0), ran RAT. 1. I compared the git repo with the contents of the source distro. The LICENSE file was different. Not a blocker for release, but after release, please update the LICENSE fi

Re: [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-18 Thread Francis Chuang
Thanks for reviewing and voting on this release, Julian. Regarding 1, it looks like the LICENSE file in the source distro is generated during the gradle build, leading it to drift from the one committed in git. Vladimir, can you advise what's the best way to resolve this? For 3, I'll update

Re: [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-18 Thread Stamatis Zampetakis
Ubuntu 18.04.4 LTS, jdk1.8.0_251, Gradle wrapper * Checked signatures and checksums OK * Went over release note OK * Built from git tag and run tests (./gradlew clean build) OK * Built from source artifacts and run tests OK * Built and run Calcite (./gradlew clean build) using the staged Mave

Re: [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-19 Thread Julian Hyde
Build tools generating/modifying source code is an anti-pattern. The LICENSE file is source code, because it is included in the source distribution. It doesn’t matter whether our build tool is written in Gradle or MVS-360 assembly language. It is a tool and it needs to serve our interests. Jul

Re: [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-19 Thread Vladimir Sitnikov
Maven-based build resulted in non-compliant release artifacts. Now you complain that "files differ" yet you seem to completely ignore the licensing. Vladimir

[RESULT] [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-21 Thread Francis Chuang
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 3 binding +1s: Francis Chuang Julian Hyde Stamatis Zampetakis No 0s or -1s. Therefore, I am delighted to announce that the proposal to release Apache Calcite Avatica 1.17.0 ha

Re: [RESULT] [VOTE] Release apache-calcite-avatica-1.17.0 (release candidate 0)

2020-06-21 Thread Danny Chan
Thanks for the great work, Francis ~ Best, Danny Chan 在 2020年6月22日 +0800 AM7:11,Francis Chuang ,写道: > Thanks to everyone who has tested the release candidate and given their > comments and votes. > > The tally is as follows. > > 3 binding +1s: > Francis Chuang > Julian Hyde > Stamatis Zampetakis >