[CANCEL] [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-21 Thread Francis Chuang
The vote for Apache Calcite Avatica Go 3.0.0, release candidate 0 has been cancelled. A new release will be tagged as 3.0.0-rc1 and will be available for voting soon. Francis

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-21 Thread Julian Hyde
Apache custom is to use the [CANCEL] prefix, i.e. [CANCEL] [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0) And the same goes for [RESULT]. On Fri, Apr 20, 2018 at 7:46 PM, Francis Chuang <francischu...@apache.org> wrote: > The vote for Apache Calcite Avatica Go 3.0.

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-20 Thread Francis Chuang
The vote for Apache Calcite Avatica Go 3.0.0-rc0 has been canceled. I will make a rc1 and start a new vote. Francis On 18/04/2018 6:43 PM, Francis Chuang wrote: Hi all, I have created a release for Apache Calcite Avatica Go, release candidate 0. The release notes are available here:

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-20 Thread Julian Hyde
I agree that the script to build the release should be part of the source code. And the script that checks for headers is part of that. The "case" statement is actually important, because it gives us a place to document (and justify) files without headers, and other files of interesting

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-19 Thread Francis Chuang
Regarding the gopher.png file: I have removed it and replaced it with the Calcite logo (calcite.png) this should avoid any licensing issues. Francis On 19/04/2018 11:47 AM, Julian Hyde wrote: Thanks for starting the vote. A few questions/comments before I cast my vote. Not all of them are

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Francis Chuang
Hey Julian, I was looking at integrating the script to exclude files without the license header from the release artifacts. I don't think we will need to exclude anything other than the files in the dist/ .git/ folders (which are already ignored using tar --exclude), because all the files in

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Francis Chuang
Hey Julian, Please see responses inline. On 19/04/2018 11:47 AM, Julian Hyde wrote: Thanks for starting the vote. A few questions/comments before I cast my vote. Not all of them are release blockers, by any means. I see there are tabs in the source code. Is this usual for go? For Go, code is

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Julian Hyde
Thanks for starting the vote. A few questions/comments before I cast my vote. Not all of them are release blockers, by any means. I see there are tabs in the source code. Is this usual for go? What is the purpose of gopher.png? Where did it come from? What is its license? Do you know what is

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Francis Chuang
Thanks, Michael! I opened a PR [1] to fix issues identified with the documentation and site during the voting process. Francis [1] https://github.com/apache/calcite-avatica-go/pull/20 On 19/04/2018 12:22 AM, Michael Mior wrote: +1 (binding) Thanks Frnacis! One minor note: the manual

Re: [VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Michael Mior
+1 (binding) Thanks Frnacis! One minor note: the manual instructions for testing say "go test-v" (there's a space missing). -- Michael Mior mm...@uwaterloo.ca 2018-04-18 4:43 GMT-04:00 Francis Chuang : > Hi all, > > I have created a release for Apache Calcite Avatica

[VOTE] Release calcite-avatica-go-3.0.0 (release candidate 0)

2018-04-18 Thread Francis Chuang
Hi all, I have created a release for Apache Calcite Avatica Go, release candidate 0. The release notes are available here: https://github.com/apache/calcite-avatica-go/blob/master/site/go_history.md The commit to be voted on: