Re: INSERT with the JdbcAdapter

2016-12-05 Thread Christian Tzolov
Thanks for the feedback. I will review the comments in the ticket Source expressions with sub-query are hard. Maybe you can represent them > using RexSubQuery; and maybe RelDecorrelator can help; I’m not sure. In any > case, I think you should defer them to another case. > Indeed it will be nice

Re: INSERT with the JdbcAdapter

2016-12-05 Thread Julian Hyde
Thanks - I’ve added some comments to CALCITE-1527. Source expressions with sub-query are hard. Maybe you can represent them using RexSubQuery; and maybe RelDecorrelator can help; I’m not sure. In any case, I think you should defer them to another case. In this case, it seems that you have impl

Re: INSERT with the JdbcAdapter

2016-12-05 Thread Christian Tzolov
Here it goes :) - JIRA: https://issues.apache.org/jira/browse/CALCITE-1527 - PR: https://github.com/apache/calcite/pull/334 Seems bit more involving than expected. In addition to the Sql implementation, it requires changes on the SQL parsing side as well as the handling for the non-ResultSet resp

Re: INSERT with the JdbcAdapter

2016-11-30 Thread Julian Hyde
“Unfortunate” is one word for it. If Calcite were complete it would be considerably more expensive. :) You figured out how to implement OVER, so I’d look in a similar place for DML. Julian > On Nov 30, 2016, at 1:42 PM, Christian Tzolov wrote: > > Thanks Julian, this is unfortunate as it unde

Re: INSERT with the JdbcAdapter

2016-11-30 Thread Christian Tzolov
Thanks Julian, this is unfortunate as it undermines the idea of having jdbc wrapper in front of HAWQ. I will log Jira tickets. How difficult do you think would be to provide DML support for the JDBC adapter? If i am to take a look at it where should look first? Cheers, Christian On 30 November 2

Re: INSERT with the JdbcAdapter

2016-11-30 Thread Julian Hyde
It’s a missing feature. The JDBC adapter does not currently do DML. Can you please log a JIRA case to track. Julian > On Nov 30, 2016, at 7:56 AM, Christian Tzolov wrote: > > A test to reproduce the problem: > > @Test public void testJdbcAdapterInsert() { > > CalciteAssert.model(JdbcTest.

Re: INSERT with the JdbcAdapter

2016-11-30 Thread Christian Tzolov
A test to reproduce the problem: @Test public void testJdbcAdapterInsert() { CalciteAssert.model(JdbcTest.FOODMART_MODEL) .enable(CalciteAssert.DB == POSTGRESQL) .query("INSERT INTO \"foodmart\".\"expense_fact\"(\n" + " \"store_id\", \"account_id\", \"exp_da

INSERT with the JdbcAdapter

2016-11-30 Thread Christian Tzolov
Hi, The insert statement via the JdbcAdapter fails with "rel#78:Subset#1.ENUMERABLE.[]] could not be implemented;" I'm testing SQL inserts using the foodmart dataset and postgresql configured as a backend. Following insert works find on postgresql but fails when run through the jdbc adapter: "I