Re: PR3502(lambda expressions) Review Request

2023-11-14 Thread Julian Hyde
I have reviewed. It looks good, and I’m sure we can get this in before 1.37. Let’s discuss further on the PR and in https://issues.apache.org/jira/browse/CALCITE-3679. > On Nov 13, 2023, at 7:08 PM, Hongyu Guo wrote: > > Hi Julian, > > Thanks for your explanation. > I think we can add

Re: PR3502(lambda expressions) Review Request

2023-11-13 Thread Hongyu Guo
Hi Julian, Thanks for your explanation. I think we can add support for lambda expressions in CTE syntax later, for example: ``` with f as (x, y) -> x + y select f(c1, c2) from t; ``` Another thing, I provided the wrong PR link, and the correct one should be: [1]

Re: PR3502(lambda expressions) Review Request

2023-11-13 Thread Julian Hyde
Thank you. I’ll take a look. For what it's worth, I take issue the people (not you - they are in Spark and/or Presto) who originally describe this feature as ‘lambdas’, ‘higher-order functions’ or ‘function values’. The lambdas can only be used within that particular function call, not passed

PR3502(lambda expressions) Review Request

2023-11-13 Thread Hongyu Guo
Hi devs, I have opened a PR regarding lambda expressions, Calcite will support lambda expressions like `(a, b) - > a+ b` in function parameters if this PR is merged. This PR includes the following: - Parse, validation, SqlToRel and RelToSql for lambda expressions. - Execution of higher-order