Re: Question: Hints & Rules

2021-05-30 Thread JiaTao Tao
Thanks Danny Regards! Aron Tao Danny Chan 于2021年5月27日周四 下午8:31写道: > Jia Tao ~ > The hints is production ready, we have implements many hints internal for > our Flink engine, such as the table hints and query hints. > > The `RelBuilder#project` was modified to support hints already, one

Re: Question: Hints & Rules

2021-05-27 Thread Danny Chan
Jia Tao ~ The hints is production ready, we have implements many hints internal for our Flink engine, such as the table hints and query hints. The `RelBuilder#project` was modified to support hints already, one reason for hints lost is that the projection are dropped for some reason( maybe some

Re: Question: Hints & Rules

2021-05-27 Thread JiaTao Tao
Hi Indeed, there's some situation will lose hints, like RelBuilder#project, we just construct a project without hints(ImmutableList.of()), so it will lose hints too. IMO, it's not ready for production, so finally, we give up this feature. Currently, hints occurs some times in the mail list, proves

Re: Question: Hints & Rules

2021-05-26 Thread Danny Chan
Hi ~ We have interface RelHintsPropagator for hints propagation customization, but you may need to modify the code of the rule a little bit. Best, Danny Chan Taras Ledkov 于2021年5月26日周三 下午7:26写道: > Hi, > > I am trying to figure out how to use hints correctly. > > My case: > I've registered

Re: Question: Hints & Rules

2021-05-26 Thread Julian Hyde
My fear, when we introduced hints, was that there would be many cases where people would hope that rules propagate hints and the rules do not; and that in some cases, the expected behavior isn't even clear. Maybe this can be addressed by the power of open source: people find an issue, submit a

Re: Question: Hints & Rules

2021-05-26 Thread Stamatis Zampetakis
Hi Taras, I haven't used hints much but what you describe sounds like a bug. I would expect that rules should preserve hints if possible. I guess that if a rule removes an operator completely then it may not make sense to retain the hints. Best, Stamatis On Wed, May 26, 2021, 1:26 PM Taras

Question: Hints & Rules

2021-05-26 Thread Taras Ledkov
Hi, I am trying to figure out how to use hints correctly. My case: I've registered hint for Aggregate node to force expand DISTINCT aggregate. Because is some cases plan with DISTINCT aggregate to JOIN cannot be chosen by the cost. I see that different rules treat hints differently. e.g.: -