RE: Null literals in AggregateReduceFunctionsRule

2017-02-07 Thread Anton Mushin
AM To: dev@calcite.apache.org Cc: Timo Walther Subject: Re: Null literals in AggregateReduceFunctionsRule Adding a cast around the null literal makes sense. I would use “rexBuilder.makeCast(type, constantNull())” rather than “rexBuilder.makeNullLiteral(type.getSqlTypeName())” because there’s a

Re: Null literals in AggregateReduceFunctionsRule

2017-02-06 Thread Julian Hyde
Adding a cast around the null literal makes sense. I would use “rexBuilder.makeCast(type, constantNull())” rather than “rexBuilder.makeNullLiteral(type.getSqlTypeName())” because there’s a chance that the type needs precision & scale. Can you please create a Calcite jira case and submit a pull