Vladimir
> > > >
> > > > ср, 6 нояб. 2019 г. в 03:52, Haisheng Yuan :
> > > >
> > > >> Hi Vladimir,
> > > >>
> > > >> The code in PHYSICAL convention L44 looks weird, I think it always
> > > >> returns true.
> >
te-optimizer/blob/master/src/main/java/devozerov/HazelcastConventions.java#L44
> > >>
> > >> Try this:
> > >>
> > >> fromTraits.containsIfApplicable(Convention.PHYSICAL)
> > >> && toTraits.containsIfApplicable(Convention.PHYSIC
ion.PHYSICAL)
> >> && toTraits.containsIfApplicable(Convention.PHYSICAL);
> >>
> >>
> >> Adding a AbstractConverter on logical operators is meaningless. Calcite
> >> is mixing the concept of logical and physical together, which is sad.
> >>
>
al operators is meaningless. Calcite
>> is mixing the concept of logical and physical together, which is sad.
>>
>> BTW, using 2 conventions is not appropriate and wrong.
>>
>> - Haisheng
>>
>> --------------------------
-
> 发件人：Vladimir Ozerov
> 日 期：2019年11月05日 18:02:15
> 收件人：Haisheng Yuan
> 抄 送：dev@calcite.apache.org (dev@calcite.apache.org) >
> 主 题：Re: Re: Problem with converters and possibly rule matching
>
> Hi Haisheng,
>
> think I already tried something very si
Haisheng
--
发件人：Vladimir Ozerov
日 期：2019年11月05日 18:02:15
收件人：Haisheng Yuan
抄 送：dev@calcite.apache.org (dev@calcite.apache.org)
主 题：Re: Re: Problem with converters and possibly rule matching
Hi Haisheng,
think I already tried something very similar to what you explained, but it
gav
Hi Haisheng,
think I already tried something very similar to what you explained, but it
gave not an optimal plan. Please let me describe what I did. I would
appreciate your feedback.
1) We start with a simple operator tree Root <- Project <- Scan, where the
root is a final aggregator in the dist
Hi Vladimir,
This is still can be done through top-down request approach.
PhysicalFilter operator should request ANY distribution from child operator,
unless there is outer reference in the filter condition, in which case,
PhysicalFilter should request SINGLETON or BROADCAST distribution. So in
Why do you need 2 conventions? I think 1 "Hazelcast" is enough. Usually logical
operators are ones with NONE convention.
Regarding with physical->logical, you can modify the rule instance to match
logical operators or NONE convention only.
- Haisheng
---
