Re: [DISCUSS] Assigning reviewers

2022-02-14 Thread Ruben Q L
have never committed anything on it; so even though they do not appear on the history, they could perfectly contribute to the PR review. I share Zoltan's concerns about "forcing" committers to act as reviewers in parts of the project that they might not know. Wouldn't they f

Re: [DISCUSS] Assigning reviewers

2022-02-13 Thread Yanjing Wang
including contributors to participate in the review process. Zoltan Haindrich 于2022年2月11日周五 18:16写道: > Hey, > > > I think the main problem is still the lack of active committers/reviewers > > and not so much the assignment. > > Totally agree - I think this is the

Re: [DISCUSS] Assigning reviewers

2022-02-11 Thread Zoltan Haindrich
Hey, I think the main problem is still the lack of active committers/reviewers and not so much the assignment. Totally agree - I think this is the core of the problem; the assign-by-files could somewhat help pulling in the right people - but will not make the job done. We could opt for

Re: [DISCUSS] Assigning reviewers

2022-02-10 Thread Julian Hyde
advance for a particular release (which I’d estimates takes between 1 and 3 days, on average) and they deliver on their commitment. Could we emulate that for reviewers? Suppose that six committers volunteer to review and merge up to six PRs per quarter. When they’ve done their six, we stop

Re: [DISCUSS] Assigning reviewers

2022-02-07 Thread Stamatis Zampetakis
Hello, I think the main problem is still the lack of active committers/reviewers and not so much the assignment. Nevertheless, things would be a bit better if we had people assigned to PRs. This could certainly help at least offload some work from Julian and possibly sensibilize more people

Re: [DISCUSS] Assigning reviewers

2022-02-05 Thread Jing Zhang
the real situation, is it possible to develop more than one members on each module? 3. It could be helpful to assign reviewers for a new pull request. [1] https://calcite.apache.org/community/#project-members Best, Jing Zhang Julian Hyde 于2022年2月4日周五 02:18写道: > I make many contributions to this

[DISCUSS] Assigning reviewers

2022-02-03 Thread Julian Hyde
I make many contributions to this project, in the form of code, answering questions, leading design discussions, and clarifying bugs and feature requests. I review more changes than any other project member. My reward is that I am pestered, daily, with people pleading for me to review their changes

Re: Reviewers

2018-05-23 Thread Josh Elser
I'd request that Avatica remains with me as the core owner. It's low-volume enough that it helps me filter some of the rest of the "noise" :) On 5/22/18 1:09 PM, Julian Hyde wrote: It gets assigned to me because I am owner of the “core” component in JIRA. Should we remove owners from all com

Re: Reviewers

2018-05-22 Thread Shuyi Chen
I think this is a reasonable idea. We should have owners conceptually for each component, but not physically assigned. Also, I like the idea of sending an email to dev if no one engaged with 24 hours, maybe add a title like [REQUEST REVIEW] [], so committers can better filter the emails. On Tue, M

Re: Reviewers

2018-05-22 Thread Francis Chuang
I think this is a good idea. Francis On 23/05/2018 3:09 AM, Julian Hyde wrote: It gets assigned to me because I am owner of the “core” component in JIRA. Should we remove owners from all components? On May 21, 2018, at 6:04 PM, Alex Xu wrote: Agree ! ptr.bo...@gmail.com 于2018年5月22日 周二上午4:

Re: Reviewers

2018-05-22 Thread Julian Hyde
It gets assigned to me because I am owner of the “core” component in JIRA. Should we remove owners from all components? > On May 21, 2018, at 6:04 PM, Alex Xu wrote: > > Agree ! > > ptr.bo...@gmail.com 于2018年5月22日 周二上午4:26写道: > >> Hello, >> >> I've just fired at you Julian a pull request, ju

Re: Reviewers

2018-05-21 Thread Alex Xu
Agree ! ptr.bo...@gmail.com 于2018年5月22日 周二上午4:26写道: > Hello, > > I've just fired at you Julian a pull request, just like you said. Sorry for > that. > > Currently, each bug at JIRA is assigned to you automatically - this can be > misleading, when someone is logging a bug and deliver a fix just af

Re: Reviewers

2018-05-21 Thread ptr.bo...@gmail.com
Hello, I've just fired at you Julian a pull request, just like you said. Sorry for that. Currently, each bug at JIRA is assigned to you automatically - this can be misleading, when someone is logging a bug and deliver a fix just after. This is my case. Maybe it would be better to leave a JIRA iss

Reviewers

2018-05-21 Thread Julian Hyde
Calcite contributors, If you are submitting a PR, please stop tagging me personally in JIRA cases to review your PR. I do review a lot of PRs in this project but I am short of time and. If you tag me, other committers will be discouraged from doing it. Of course we are delighted that you are co