Re: RexExecutorImpl and RexSubQuery

2023-02-15 Thread Julian Hyde
Can't really use a PR if it's just a bit of code that seems to be better than the previous bit of code. We'd love contributions but they are best packaged as follows: > Here is a bug. > And here is a jira case describing how other people might experience the bug. > And here is a PR that includes

Re: RexExecutorImpl and RexSubQuery

2023-02-14 Thread Jonathan Sternberg
I took a deeper look today following your recommendation and ran into a problem when I got into the implementation of the program builder. I think the problem might be higher up since the error appears to be that it's attempting to reduce a subquery as a constant. I found this section of code:

Re: RexExecutorImpl and RexSubQuery

2023-02-13 Thread Julian Hyde
We need to decide whether a RexSubQuery can appear inside a RexProgram. If yes, then RegisterInputShuttle should be extended to handle it, register it, and then it will become a RexLocalRef. If no, you will need to apply a rule to expand all RexSubQuery instances before the phase where you

RexExecutorImpl and RexSubQuery

2023-02-13 Thread Jonathan Sternberg
Hi, I'm attempting to update some code that previously used `withExpand(true)` to use `withExpand(false)`. This has resulted in some plans that previously used left joins to start using `SCALAR_QUERY`. The code also uses a HepPlanner