Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

2021-12-28 Thread Michael Mior
Thanks Julian for CALCITE-4885! I've avoided trying to do anything with the notebook repository I created a while back since test artifacts are no longer published. It would be great to get that up to date with the latest Calcite version. -- Michael Mior mm...@apache.org Le mer. 22 déc. 2021 à

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

2021-12-22 Thread Gavin Ray
Julian, this is awesome to hear -- and thank you for the pointers to this "FixtureTest" file, I hadn't found that one yet =) A couple of the helper methods and patterns seem particularly useful, like this one for setting everything up with a particular test schema: final SchemaPlus rootSchema

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

2021-12-22 Thread Julian Hyde
Gavin, I’m working on this in https://issues.apache.org/jira/browse/CALCITE-4885 . Take a look at FixtureTest [1] to get an idea of how parser, validator, sql-to-rel or rule tests would look in your project. My one concern is that once we

Re: Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

2021-12-22 Thread Vladimir Sitnikov
Gavin, Please check sample schemata in https://github.com/apache/calcite/tree/7a7b37fc1f4bd2121643539b0fd8e9c4f0f8ed09/testkit/src/main/java/org/apache/calcite/test/schemata If you find useful schemas, don't hesitate filing a PR to add samples to /testkit/ Vladimir

Why not make the "test" namespace public, or move to a separate Maven module that main pulls in as a "testOnly" dependency?

2021-12-22 Thread Gavin Ray
I am still learning the fundamentals of Calcite's API, and I've found that there are pre-made schemas and other utilities meant for testing inside of the Calcite repo. Unfortunately it seems like a lot of these objects are private, because they aren't meant to be a part of the public API. I've