calcite-core 1.28.0 now depends on kotlin-stdlib?

I see that the latest release of calcite-core brings in kotlin-stdlib as a dependency., org.jetbrains.kotlin kotlin-stdlib-jdk8 1.5.31 I looked over the release notes, and I cannot find anything that mentions this, anyone knows why is this new dependency required? (u

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

This is a surprise to me too. Vladimir? > On Nov 29, 2021, at 4:45 PM, Zoltan Farkas > wrote: > > I see that the latest release of calcite-core brings in kotlin-stdlib as a > dependency., > > > org.jetbrains.kotlin > kotlin-stdlib-jdk8 > 1.5.31 > > > I looked over the

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

Hopefully I didn't introduce this when doing the immutables work... I don't think I did. But I'm also weak on gradle... On Mon, Nov 29, 2021, 6:23 PM Julian Hyde wrote: > This is a surprise to me too. Vladimir? > > > On Nov 29, 2021, at 4:45 PM, Zoltan Farkas > wrote: > > > > I see that the lat

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

If it is a transitive dependency, then it is a transitive dependency. Otherwise it is a bug. I'm sure calcite-core itself does not use kotlin stdlib since core/src/kotlin does not exist yet. Vladimir

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

>since core/src/kotlin does not exist yet. I mean core/src/main/kotlin does not exist yet Vladimir

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

According to the published pom it is a direct dependency: https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.28.0/calcite-core-1.28.0.pom > On Nov 29, 2021, at 11:41 PM, Vladimir Sitni

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

Can you file a JIRA? We should address before 1.29. On Tue, Nov 30, 2021 at 6:40 AM Zoltan Farkas wrote: > According to the published pom it is a direct dependency: > https://repo1.maven.org/maven2/org/apache/calcite/calcite-core/1.28.0/calcite-core-1.28.0.pom > < > https://repo1.maven.org/maven

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

It seems that Vladimir fixed this already in [1]. [1] https://github.com/apache/calcite/commit/f3e2f041567e35e65464676d3171db3b5f2ddf9c On Tue, Nov 30, 2021 at 7:50 PM Jacques Nadeau wrote: > Can you file a JIRA? We should address before 1.29. > > On Tue, Nov 30, 2021 at 6:40 AM Zoltan Farkas

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

Nice. Anyone know if there is a tool to fingerprint dependencies between releases so we can avoid introducing new dependencies accidentally? On Tue, Nov 30, 2021 at 1:26 PM Stamatis Zampetakis wrote: > It seems that Vladimir fixed this already in [1]. > > [1] > > https://github.com/apache/calci

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

It’s quite easy to script. For example, git checkout calcite-1.27.0 ./gradlew dependencies > /tmp/d27.txt git checkout calcite-1.28.0 ./gradlew dependencies > /tmp/d28.txt diff /tmp/d2{7,8}.txt I posted the output at https://gist.github.com/julianhyde/9ca5915bfb91494b7f91405ad15d698e

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

Any opinions on whether we should formalize into some kind of release verification step (manual or automatic)? On Thu, Dec 2, 2021 at 5:22 PM Julian Hyde wrote: > It’s quite easy to script. For example, > > git checkout calcite-1.27.0 > ./gradlew dependencies > /tmp/d27.txt > git checkout calcit

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

It can't really be fully automatic because sometimes we may want to legitimately add a new dependency. I would be interested in thinking about how we could make sure unwanted dependencies don't creep in. Part of the problem is that the release manager may not know what dependencies should or should

Re: calcite-core 1.28.0 now depends on kotlin-stdlib?

Suppose that the dependencies were uploaded to the RC site, such as https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc0/ . Then people voting on the RC could compare those dependencies with the depen