Re: About 2 commits of today...

2013-11-18 Thread Willem jiang
Hi Babak, Yeah, we need to add the String parameter to let us know better about what’s wrong with the assertTrue(). For the new added operations in CxfRsEndpoint, I was think the user won’t access it from out side of CxfRsEndpoint, but we could add the getMethod for it. I will commit a quic

Re: About 2 commits of today...

2013-11-18 Thread Babak Vahdat
Hi Willem, Thanks for the heads-up & your quick fixes, though I've got two questions: - Do you see any specific reason why we should NOT change those two assertTrue() statements as suggested, so that instead of getting a stack trace like: https://builds.apache.org/job/Camel.trunk.fulltest/org.ap

Re: About 2 commits of today...

2013-11-18 Thread Hadrian Zbarcea
For what is worth, the test was failing with all JDKs not just OpenJDK. Not sure if hardcoding the cipher suite is the best fix in the long run, but it does work. Hadrian On 11/18/2013 09:56 PM, Willem jiang wrote: Hi Babak, Thanks for the review, I just updated the code with some suggestio

Re: About 2 commits of today...

2013-11-18 Thread Willem jiang
Hi Babak, Thanks for the review, I just updated the code with some suggestion of you. For the SSLContextParametersTest it is caused by the different JDKs handles the SSL related setting differently, I just updated the code to avoid the null collection returned. -- Willem Jiang Red Hat, Inc.

Re: About 2 commits of today...

2013-11-18 Thread Hadrian Zbarcea
Good catch Babak. Thanks, Hadrian On 11/18/2013 02:59 PM, Babak Vahdat wrote: Hi Just spotted couple of things on the commit mailing list of today: http://git-wip-us.apache.org/repos/asf/camel/diff/000581e6 This commit now makes the following asserts passing: assertStartsWith((String[]) n

About 2 commits of today...

2013-11-18 Thread Babak Vahdat
Hi Just spotted couple of things on the commit mailing list of today: http://git-wip-us.apache.org/repos/asf/camel/diff/000581e6 This commit now makes the following asserts passing: assertStartsWith((String[]) null, "foo"); assertStartsWith(new String[] {}, "foo"); assertStartsWith((Colle

Re: [DISCUSS] - Apache Camel 2.12.2 release later this month?

2013-11-18 Thread Claus Ibsen
On Mon, Nov 18, 2013 at 1:54 AM, Hadrian Zbarcea wrote: > There are test failure(s) I need to look at: > > Are there any other issues you absolutely need in 2.12.2? > CAMEL-6974 would be good for the users of camel-salesforce. If you beat any of us to it, then just apply the patch on master and

Re: [DISCUSS] - Apache Camel 2.12.2 release later this month?

2013-11-18 Thread Hadrian Zbarcea
We usually do all the patch releases at roughly the same time, so I was planning on doing that too. Hadrian On 11/18/2013 03:46 AM, Christian Müller wrote: Not for me. I'm fine with the assigned issues for 2.12.2. I'm wondering whether we should also release 2.11.3 in short term. I could do

Camel-Gora component

2013-11-18 Thread Ioannis Polyzos
Hi everyone, The past few days I have worked towards creating a camel-gora component and I would like to kindly contribute this work back to the community. I came across the CAMEL-4817 issue which is about such a component and a patch with the sou

camel pull request: Removed clearing of field 'Name' to allow upserts with ...

2013-11-18 Thread mdarcemont
GitHub user mdarcemont opened a pull request: https://github.com/apache/camel/pull/57 Removed clearing of field 'Name' to allow upserts with custom external I... Hi, The component "camel-salesforce" doesn't allow upserts with a custom external ID. We have a data m

Re: [DISCUSS] - Apache Camel 2.12.2 release later this month?

2013-11-18 Thread Christian Müller
Not for me. I'm fine with the assigned issues for 2.12.2. I'm wondering whether we should also release 2.11.3 in short term. I could do this next week or so (comming back to a "normal" work load in my day job...). Best, Christian On Mon, Nov 18, 2013 at 1:54 AM, Hadrian Zbarcea wrote: > Ther