Cyclomatic complexity of camel-redis

2016-05-30 Thread arno noordover
The CommandDispatcher in redis-component has a high cyclomatic complexity. It is relatively simple to extract all redis-command to its own class and put these classes in a HashMap. This means that a lot of classes will emerge (one for every entry in the Command-enum). But it also means that extensi

[GitHub] camel pull request: Camel-8668

2016-05-30 Thread anoordover
GitHub user anoordover opened a pull request: https://github.com/apache/camel/pull/1006 Camel-8668 Tried to solve CAMEL-8668. Solution isn't backward compatible. Maybe introduce new mongodb3 endpoint. Comments are appreciated. You can merge this pull request into a Git reposito

Re: Web site issue

2016-05-30 Thread Charles Moulliard
You are right. This is a edit issue on the wiki page. Is it possible to make a rollback to a previous version, ... ? On Fri, May 27, 2016 at 3:12 PM, Daniel Kulp wrote: > > > On May 27, 2016, at 4:31 AM, Charles Moulliard wrote: > > > > Hi, > > > > It appears that we have some issues with the H

[GitHub] camel pull request: CAMEL-9996: Resolve RestComsumerFactory and Re...

2016-05-30 Thread johnpoth
GitHub user johnpoth opened a pull request: https://github.com/apache/camel/pull/1005 CAMEL-9996: Resolve RestComsumerFactory and RestApiConsumerFactory as… … Camel Components first https://issues.apache.org/jira/browse/CAMEL-9996 You can merge this pull request into a

Re: ServiceCall : ServiceCallServerListStrategy

2016-05-30 Thread Claus Ibsen
On Mon, May 30, 2016 at 11:09 AM, Luca Burgazzoli wrote: > And what about returning a List instead of a Collection ? > A little bit less generic but would make it more efficient to > implement load balancers (i.e. avoid to make a new List for each call) > --- Yeah sure feel free to do changes to

Re: ServiceCall : ServiceCallServerListStrategy

2016-05-30 Thread Luca Burgazzoli
And what about returning a List instead of a Collection ? A little bit less generic but would make it more efficient to implement load balancers (i.e. avoid to make a new List for each call) --- Luca Burgazzoli On Sat, May 28, 2016 at 9:32 AM, Claus Ibsen wrote: > Hi > > Yeah that is a good idea

Re: Consul ServiceCall EIP

2016-05-30 Thread Claus Ibsen
On Mon, May 30, 2016 at 10:49 AM, Luca Burgazzoli wrote: > So like serviceCall("myServiceCall").configurationRef("myConf") ? Yeah there is already a DSL for that named serviceCallConfiguration("myConf") > --- > Luca Burgazzoli > > > On Mon, May 30, 2016 at 10:26 AM, Claus Ibsen wrote: >> On

Re: Consul ServiceCall EIP

2016-05-30 Thread Luca Burgazzoli
So like serviceCall("myServiceCall").configurationRef("myConf") ? --- Luca Burgazzoli On Mon, May 30, 2016 at 10:26 AM, Claus Ibsen wrote: > On Mon, May 30, 2016 at 10:16 AM, Luca Burgazzoli > wrote: >> do you mean something like serviceCallRef("myServiceCall") ? >> --- > > No you need to prov

Re: Consul ServiceCall EIP

2016-05-30 Thread Claus Ibsen
On Mon, May 30, 2016 at 10:16 AM, Luca Burgazzoli wrote: > do you mean something like serviceCallRef("myServiceCall") ? > --- No you need to provide - a) name of service to call - b) reference to configuration of service a = mandatory b = optional. As if there is only 1 configuration then use t

Re: Consul ServiceCall EIP

2016-05-30 Thread Luca Burgazzoli
do you mean something like serviceCallRef("myServiceCall") ? --- Luca Burgazzoli On Sun, May 29, 2016 at 9:42 AM, Claus Ibsen wrote: > On Thu, May 26, 2016 at 7:30 PM, Luca Burgazzoli > wrote: >> --- >> Luca Burgazzoli >> >> >> On Thu, May 26, 2016 at 7:06 PM, Claus Ibsen wrote: >>> Hi Luca >