Re: Consul ServiceCall EIP

2016-05-31 Thread Claus Ibsen
Hi Looks good there is only a few spots I have some comments. - There is some code that has not null check for load balancer / server list strategy. The kubernetes component can do without that when you use ENV or DNS as lookup. - There was a place where you do some logging and it says Consul wh

Re: Cyclomatic complexity of camel-redis

2016-05-31 Thread arno noordover
Great solution for choosing what processor to call on the basis of the value of a specific header. I will use this for this solution. I also have another problem in the redis solution. In the class CommandDispatcher a lot of "getters" on different headers or sometimes the same header are defined.

Re: Cyclomatic complexity of camel-redis

2016-05-31 Thread Luca Burgazzoli
You may also have a look at HeaderSelectorProducer which let you to use annotations and/or lambdas as callbacks for a given header i.e. : https://github.com/apache/camel/blob/master/components/camel-consul/src/main/java/org/apache/camel/component/consul/enpoint/ConsulAgentProducer.java https://gi

Re: Clustered routes in master/slave mode

2016-05-31 Thread Bilgin Ibryam
Hi Claus, I think such an API is long due in Camel I've documented the various ways for having sindleton Camel routes on my blog long ago. http://www.ofbizian.com/2014/01/masterslave-failover-for-camel-routes.html Something related again for clustering... We have a number of statefil EIPs. Havi

Re: Cyclomatic complexity of camel-redis

2016-05-31 Thread Bilgin Ibryam
Hi arno, With modern javac and JVMs I don't think there will be any performance or footprint impact from having one or more classes. Apart from CC, consider also whether the code will be easier to understand/maintain and extend. If you belive it will be bettter, then go for it. we at Camel comm

Re: Consul ServiceCall EIP

2016-05-31 Thread Luca Burgazzoli
I've committed some more code to my branch [2], it is not yet complete (i.e. I still have to make ribbon code to use the new common classes and some APIs are not clean enough) but a feedback would be really welcome. --- Luca Burgazzoli On Mon, May 30, 2016 at 10:55 AM, Claus Ibsen wrote: > On M

Camel RabbitMQ :: Publisher Acknowledgment

2016-05-31 Thread frederic.gendebien
Hello everybody, I would like to use camel-rabbitmq with Camel 2.16.3 running inside a Karaf, but I noticed that Publisher Acknowledgement was implemented only in version 2.17.x. Isn't it possible to backport that functionality in Camel 2.16.x. Or do you know how to have the same behavior with c

[GitHub] camel pull request: CAMEL-9996: Resolve RestComsumerFactory and Re...

2016-05-31 Thread johnpoth
Github user johnpoth closed the pull request at: https://github.com/apache/camel/pull/1005 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en