Re: Getting ready for Camel 2.22 Release with SB2 support

2018-05-23 Thread Andrea Cosentino
Yes, it is, but some bundles are available already -- Andrea Cosentino  -- Apache Camel PMC Member Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github: oscerd On Thursday, May 24, 2018, 7:35:01 AM GMT+2,

Re: Getting ready for Camel 2.22 Release with SB2 support

2018-05-23 Thread Claus Ibsen
Hi There is a few new component that needs documentation in the src/main/docs folder, such as camel-rx2 and camel-reactor On Wed, May 23, 2018 at 9:08 AM, Claus Ibsen wrote: > Hi > > I want to let us get started early on preparing for the upcoming and > anticipated

Re: Getting ready for Camel 2.22 Release with SB2 support

2018-05-23 Thread Claus Ibsen
On Wed, May 23, 2018 at 10:17 AM, Andrea Cosentino wrote: > We need to take care of Karaf features too. Actually we have some > misalignments between bundles and JARs > Is the SMX team working on this, such as a new set of bundles to be released. > -- > Andrea

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
Of course, any image available on docker hub (or other registries) can be used. --- Luca Burgazzoli On Wed, May 23, 2018 at 11:16 PM, Alex Dettinger wrote: > Hi Luca, > > +1 as you demonstrated the use to test starters. > > I already faced a situation where a custom

Re: testcontainers

2018-05-23 Thread Alex Dettinger
Hi Luca, +1 as you demonstrated the use to test starters. I already faced a situation where a custom docker image would have helped in testing a regular camel component. Would it be in the scope of camel-testcontainers ? I mean building a custom image, pushing it to docker hub and use that

[GitHub] camel pull request #2349: Allow applications to control whether to stop rout...

2018-05-23 Thread maxfortun
GitHub user maxfortun opened a pull request: https://github.com/apache/camel/pull/2349 Allow applications to control whether to stop routes on dns lookup failure Allow applications to control whether to stop routes on dns lookup failure You can merge this pull request into a Git

Re: JUnit5, was: testcontainers

2018-05-23 Thread Zoran Regvart
Hi David, yes we can wait for that and the Surefire/Failsafe release that includes it. I think we can also add org.junit.platform:junit-platform-surefire-provider:1.2.0 dependency to the existing Surefire/Failsafe plugin configurations. As far as I understand that issue is tracking the

Re: Getting ready for Camel 2.22 Release with SB2 support

2018-05-23 Thread Andrea Cosentino
We need to take care of Karaf features too. Actually we have some misalignments between bundles and JARs -- Andrea Cosentino  -- Apache Camel PMC Member Apache Karaf Committer Apache Servicemix PMC Member Email: ancosen1...@yahoo.com Twitter: @oscerd2 Github:

Re: JUnit5, was: testcontainers

2018-05-23 Thread David Karlsen
Would you have to await for https://issues.apache.org/jira/browse/SUREFIRE-1330 to be merged to get surefire support? Den ons. 23. mai 2018 kl. 10:08 skrev Zoran Regvart : > Hi, > on the testcontainers thread I mentioned that we can switch to JUnit5. > I've attended a talk by

JUnit5, was: testcontainers

2018-05-23 Thread Zoran Regvart
Hi, on the testcontainers thread I mentioned that we can switch to JUnit5. I've attended a talk by Sam Brannen at the local JUG. I think it was a variant of the talk[1] he gave at SpringOne 2017. The key takeaway for me was that JUnit5 is forward and backward compatible, so you can run the same

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
Like: https://github.com/lburgazzoli/apache-camel/blob/CAMEL-12485/platforms/spring-boot/components-starter/camel-consul-starter/pom.xml#L67-L128 --- Luca Burgazzoli On Wed, May 23, 2018 at 9:38 AM, Luca Burgazzoli wrote: > It can be done by checking the presence

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
It can be done by checking the presence of the docker socket file or DOCKER_HOST env var --- Luca Burgazzoli On Wed, May 23, 2018 at 8:56 AM, Willem Jiang wrote: > Hi Luca, > > I guess you mean the maven profile. Please correct me if I'm wrong. > Currently I need to

Getting ready for Camel 2.22 Release with SB2 support

2018-05-23 Thread Claus Ibsen
Hi I want to let us get started early on preparing for the upcoming and anticipated release of Apache Camel 2.22, that has support for Spring Boot 2. We have this release scheduled for next month (June), and it would be good to start closing down on issues and finish up new implementations and

Re: testcontainers

2018-05-23 Thread Willem Jiang
Hi Luca, I guess you mean the maven profile. Please correct me if I'm wrong. Currently I need to user -Pdocker to enable the docker related test in my project. I'm not sure if we enable the profile by default if there is a docker command in the box. Willem Jiang Blog:

Re: testcontainers

2018-05-23 Thread Luca Burgazzoli
Hi Zoran, On Tue, May 22, 2018 at 10:03 PM, Zoran Regvart wrote: > Hi Luca, > sounds like a good idea, would be really good if we transitioned (no > need for a big bang), to JUnit 5 then we could use conditional logic > to skip those tests if for instance docker is not

Re: testcontainers

2018-05-23 Thread Claus Ibsen
+1 On Tue, May 22, 2018 at 5:35 PM, Luca Burgazzoli wrote: > Hi all, > > I've been using testcontainers [1] for a while and I found it useful > to test against non java services such as consul, etcd and so on so > I'd like to create a camel-testcontainers "component" that

Re: testcontainers

2018-05-23 Thread Onder SEZGIN
+1 On Wed, May 23, 2018 at 8:14 AM, Luca Burgazzoli wrote: > A very simple example is: > > https://github.com/lburgazzoli/apache-camel/blob/ > CAMEL-12485/platforms/spring-boot/components-starter/camel- > consul-starter/src/test/java/org/apache/camel/component/ >