Re: No tests in the File Component

2019-05-21 Thread Andrea Cosentino
Camel-file was extracted from core in camel 3. The test related to all the components we extracted from core (and related to core functionalities) are still under camel-core. Il mar 21 mag 2019, 22:58 Beto Flores ha scritto: > Hi all. > > Maybe it is a dumb question, but while I was working on C

No tests in the File Component

2019-05-21 Thread Beto Flores
Hi all. Maybe it is a dumb question, but while I was working on CAMEL-13483 [1] I realized that the camel-file component does not have tests. So, I was wondering if the tests are in other place and how I should be testing my changes in this component. Thanks for your help. Cheers, Roberto [1] h

[GitHub] [camel-k] nicolaferraro commented on issue #669: Remove depenency on Istio for Knative sources

2019-05-21 Thread GitBox
nicolaferraro commented on issue #669: Remove depenency on Istio for Knative sources URL: https://github.com/apache/camel-k/issues/669#issuecomment-494455136 The operator should make sure that annotations on the source and integration are propagated to the final container. This way, if Ist

[GitHub] [camel-k] valdar merged pull request #676: chore: support for health based on servlet available from 0.3.3-SNAPSHOT

2019-05-21 Thread GitBox
valdar merged pull request #676: chore: support for health based on servlet available from 0.3.3-SNAPSHOT URL: https://github.com/apache/camel-k/pull/676 This is an automated message from the Apache Git Service. To respond t

[GitHub] [camel-k] astefanutti commented on issue #675: Migrate to Go modules

2019-05-21 Thread GitBox
astefanutti commented on issue #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675#issuecomment-494423307 Yes, that'd be even better. It may not be practical for the k8s APIs / primitives that we extend, though restricting to them would probably be acceptable.

[GitHub] [camel-k] nicolaferraro commented on issue #675: Migrate to Go modules

2019-05-21 Thread GitBox
nicolaferraro commented on issue #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675#issuecomment-494421943 Or, a better approach would be to make sure we don't use external dependencies in the API section, that is a good practice I've seen in other projects. -

[GitHub] [camel-k] astefanutti commented on issue #675: Migrate to Go modules

2019-05-21 Thread GitBox
astefanutti commented on issue #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675#issuecomment-494408665 I assumed Camel K wasn't consumed. It seems possible to have _non-module_ consumers. It may be necessary to keep the Dep manifests around. https://github

[GitHub] [camel-k] nicolaferraro edited a comment on issue #675: Migrate to Go modules

2019-05-21 Thread GitBox
nicolaferraro edited a comment on issue #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675#issuecomment-494394313 Great job! Is it supposed to work if I import this repo from another repo using dep? Currently I'm importing the Camel K API definitions in the Kna

[GitHub] [camel-k] nicolaferraro commented on issue #675: Migrate to Go modules

2019-05-21 Thread GitBox
nicolaferraro commented on issue #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675#issuecomment-494394313 Great job! Is it supposed to work if I import this repo from another repo using dep? Currently I'm importing the Camel K API definitions in the Knative so

[GitHub] [camel-k] lburgazzoli merged pull request #673: trait(route): tls support

2019-05-21 Thread GitBox
lburgazzoli merged pull request #673: trait(route): tls support URL: https://github.com/apache/camel-k/pull/673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [camel-k] astefanutti opened a new pull request #675: Migrate to Go modules

2019-05-21 Thread GitBox
astefanutti opened a new pull request #675: Migrate to Go modules URL: https://github.com/apache/camel-k/pull/675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [camel-k-runtime] valdar merged pull request #68: add servlet support

2019-05-21 Thread GitBox
valdar merged pull request #68: add servlet support URL: https://github.com/apache/camel-k-runtime/pull/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [camel-k] lburgazzoli commented on a change in pull request #673: trait(route): tls support

2019-05-21 Thread GitBox
lburgazzoli commented on a change in pull request #673: trait(route): tls support URL: https://github.com/apache/camel-k/pull/673#discussion_r285917505 ## File path: pkg/trait/route.go ## @@ -29,10 +29,16 @@ import ( ) type routeTrait struct { - BaseTrait `proper

[GitHub] [camel-k-runtime] valdar merged pull request #66: rest: support configuring rest's configuration component/endpoint properties

2019-05-21 Thread GitBox
valdar merged pull request #66: rest: support configuring rest's configuration component/endpoint properties URL: https://github.com/apache/camel-k-runtime/pull/66 This is an automated message from the Apache Git Service. To

[GitHub] [camel-k] nicolaferraro merged pull request #671: Upgrade Operator SDK to version 0.8.0

2019-05-21 Thread GitBox
nicolaferraro merged pull request #671: Upgrade Operator SDK to version 0.8.0 URL: https://github.com/apache/camel-k/pull/671 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [camel-k] lburgazzoli commented on a change in pull request #673: trait(route): tls support

2019-05-21 Thread GitBox
lburgazzoli commented on a change in pull request #673: trait(route): tls support URL: https://github.com/apache/camel-k/pull/673#discussion_r285889388 ## File path: pkg/trait/route.go ## @@ -29,10 +29,16 @@ import ( ) type routeTrait struct { - BaseTrait `proper

[GitHub] [camel-k] astefanutti commented on a change in pull request #673: trait(route): tls support

2019-05-21 Thread GitBox
astefanutti commented on a change in pull request #673: trait(route): tls support URL: https://github.com/apache/camel-k/pull/673#discussion_r285883745 ## File path: pkg/trait/route.go ## @@ -29,10 +29,16 @@ import ( ) type routeTrait struct { - BaseTrait `proper

[GitHub] [camel-k-runtime] valdar merged pull request #67: Refactor customizer activation

2019-05-21 Thread GitBox
valdar merged pull request #67: Refactor customizer activation URL: https://github.com/apache/camel-k-runtime/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [camel-k-runtime] valdar closed issue #46: Refactor customizer activation

2019-05-21 Thread GitBox
valdar closed issue #46: Refactor customizer activation URL: https://github.com/apache/camel-k-runtime/issues/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and