Re: [DISCUSS] Extract spring-boot support

2019-12-09 Thread Andrea Cosentino
Really good work! I think this is just the first step, we can use a similar approach for the others flavours. But we need to document everything really well and we need to rethink about the release process, I guess. Thanks! -- Andrea Cosentino  -- Apache Camel

Re: [DISCUSS] Extract spring-boot support

2019-12-09 Thread Claus Ibsen
Hi +1 This is great stuff. So just think how would the developer do when eg you add a new component in the main Camel repo, lets call it components/camel-foobar ? Then you go to camel-spring-boot and want to generate a camel-foobar-starter because it should support SB too (Mind that not all comp

[DISCUSS] Extract spring-boot support

2019-12-09 Thread Guillaume Nodet
Hi everyone, Since Camel 3.0.0 has been released, and given we now have different subprojects, I'd like to discuss the possibility of moving the spring boot support into a different git repository. I see several benefits: * being able to support different versions of spring boot * better decou

[GitHub] [camel-kafka-connector] valdar commented on issue #31: run integration test insided github actions

2019-12-09 Thread GitBox
valdar commented on issue #31: run integration test insided github actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563433113 If the time is reasonable we can have them for each PR. Not sure about resources available though... ---

[GitHub] [camel-kafka-connector] valdar edited a comment on issue #31: run integration test insided github actions

2019-12-09 Thread GitBox
valdar edited a comment on issue #31: run integration test insided github actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563296282 See if it is possible to have integrations tests running as github actions, not for each PR but once in a while (nightly?

[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #31: run integration test insided gihub actions

2019-12-09 Thread GitBox
orpiske edited a comment on issue #31: run integration test insided gihub actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563406117 Personally, I prefer having the tests run for each PR, as it makes it easier to spot some issues. Depending on the resour

[GitHub] [camel-kafka-connector] orpiske commented on issue #31: run integration test insided gihub actions

2019-12-09 Thread GitBox
orpiske commented on issue #31: run integration test insided gihub actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563406117 Personally, I prefer having the tests run for each PR, as it makes it easier to spot some issues. I also think it would a

Re: Sending camel-kafka-connector and camel-website github notification mails to camel-commits instead of camel-dev?

2019-12-09 Thread Pascal Schumacher
Great! Thank you very much! Am 09.12.2019 um 20:07 schrieb Andrea Cosentino: I already created an infra issue for camel-kafka-connector. I'll do the same for the camel-website. Il lun 9 dic 2019, 20:04 Pascal Schumacher ha scritto: Hello, what about sending the camel-kafka-connector and cam

Re: Sending camel-kafka-connector and camel-website github notification mails to camel-commits instead of camel-dev?

2019-12-09 Thread Andrea Cosentino
I already created an infra issue for camel-kafka-connector. I'll do the same for the camel-website. Il lun 9 dic 2019, 20:04 Pascal Schumacher ha scritto: > Hello, > > what about sending the camel-kafka-connector and camel-website github > notification mails to the camel-commits mailing list ins

Sending camel-kafka-connector and camel-website github notification mails to camel-commits instead of camel-dev?

2019-12-09 Thread Pascal Schumacher
Hello, what about sending the camel-kafka-connector and camel-website github notification mails to the camel-commits mailing list instead of to the camel-dev mailing list? This would make the behavior consistent for camel, camel-k, camel-website and camel-kafka-connector. What do you think? Ch

[GitHub] [camel-kafka-connector] omarsmak opened a new issue #32: Better support for value Schema in the SourceTask

2019-12-09 Thread GitBox
omarsmak opened a new issue #32: Better support for value Schema in the SourceTask URL: https://github.com/apache/camel-kafka-connector/issues/32 Currently we build the `SourceRecord` with `Schema.BYTES_SCHEMA` schema. However, this can be misleading, for example, you can have body message

[GitHub] [camel-kafka-connector] valdar edited a comment on issue #31: run integration test insided gihub actions

2019-12-09 Thread GitBox
valdar edited a comment on issue #31: run integration test insided gihub actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563296282 See if it is possible to have integrations tests running as github actions, not as heach PR but once in a while (nightly? w

[GitHub] [camel-kafka-connector] valdar commented on issue #31: run integration test insided gihub actions

2019-12-09 Thread GitBox
valdar commented on issue #31: run integration test insided gihub actions URL: https://github.com/apache/camel-kafka-connector/issues/31#issuecomment-563296282 See if it is possible to have integrations tests running as github actions, not as heach PR but once in a while (nightly?). -

[GitHub] [camel-kafka-connector] valdar opened a new issue #31: run integration test insided gihub actions

2019-12-09 Thread GitBox
valdar opened a new issue #31: run integration test insided gihub actions URL: https://github.com/apache/camel-kafka-connector/issues/31 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [camel-kafka-connector] orpiske commented on issue #29: Support using an external Kafka for the tests

2019-12-09 Thread GitBox
orpiske commented on issue #29: Support using an external Kafka for the tests URL: https://github.com/apache/camel-kafka-connector/pull/29#issuecomment-563294547 It's been acting strangely when running via Github actions, so I'll review this. -

[GitHub] [camel-kafka-connector] oscerd merged pull request #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
oscerd merged pull request #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28 This is an automated message from the Apache Git Service. To resp

[GitHub] [camel-kafka-connector] oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list

2019-12-09 Thread GitBox
oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list URL: https://github.com/apache/camel-kafka-connector/issues/30#issuecomment-563284955 Opened. This is an automated message from the Apache

[GitHub] [camel-kafka-connector] oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list

2019-12-09 Thread GitBox
oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list URL: https://github.com/apache/camel-kafka-connector/issues/30#issuecomment-563284879 https://issues.apache.org/jira/browse/INFRA-19548 Th

[GitHub] [camel-kafka-connector] oscerd commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
oscerd commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563282671 So, I re-added the converter and as default we'll use that in the example, but I committed the transformatio

[GitHub] [camel-kafka-connector] davsclaus opened a new issue #30: INFRA - Turn off mail noise to Camel @dev mailing list

2019-12-09 Thread GitBox
davsclaus opened a new issue #30: INFRA - Turn off mail noise to Camel @dev mailing list URL: https://github.com/apache/camel-kafka-connector/issues/30 We need to turn off the noise from camel-kafka-connector on the @dev mailibg list like we did for the other projects its spammed wit

[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
orpiske edited a comment on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563280222 @oscerd I think it's very useful to leave this. I've been playing with a ElasticSearch test and @val

[GitHub] [camel-kafka-connector] orpiske commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
orpiske commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563280222 @oscerd I think it's very useful to leave this. I've playing with a ElasticSearch test and @valdar suggeste

[GitHub] [camel-kafka-connector] oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list

2019-12-09 Thread GitBox
oscerd commented on issue #30: INFRA - Turn off mail noise to Camel @dev mailing list URL: https://github.com/apache/camel-kafka-connector/issues/30#issuecomment-563280525 Can you raise this to INFRA? This is an automated me

[GitHub] [camel-kafka-connector] omarsmak commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
omarsmak commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563279305 Yeah makes sense, also I am working on this ticket https://github.com/apache/camel-kafka-connector/issues/

[GitHub] [camel-kafka-connector] oscerd commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
oscerd commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563278705 This was just for showing how can you create a transformation. What I can do is leaving the converter and ad

[GitHub] [camel-kafka-connector] omarsmak edited a comment on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
omarsmak edited a comment on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563275944 Converter is not more suitable here? Since we need to convert the data to `byte[]` before sending i

[GitHub] [camel-kafka-connector] omarsmak commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
omarsmak commented on issue #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28#issuecomment-563275944 Converter is not more suitable here? Since we need to convert the data to `byte[]` before sending it to Ka

[GitHub] [camel-kafka-connector] orpiske opened a new pull request #29: Support using an external Kafka for the tests

2019-12-09 Thread GitBox
orpiske opened a new pull request #29: Support using an external Kafka for the tests URL: https://github.com/apache/camel-kafka-connector/pull/29 This decouples the kafka test service from the local container and allows using an external Kafka instance for testing. It also creates the b

[GitHub] [camel-kafka-connector] oscerd opened a new pull request #28: Camel-AWS S3 example: Use a Transformation instead of a converter

2019-12-09 Thread GitBox
oscerd opened a new pull request #28: Camel-AWS S3 example: Use a Transformation instead of a converter URL: https://github.com/apache/camel-kafka-connector/pull/28 This is an automated message from the Apache Git Service. T

[GitHub] [camel-kafka-connector] orpiske closed pull request #27: Fix camel file test

2019-12-09 Thread GitBox
orpiske closed pull request #27: Fix camel file test URL: https://github.com/apache/camel-kafka-connector/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [camel-kafka-connector] orpiske opened a new pull request #27: Fix camel file test

2019-12-09 Thread GitBox
orpiske opened a new pull request #27: Fix camel file test URL: https://github.com/apache/camel-kafka-connector/pull/27 Prevent the file test from failing when the test file has been created but no content has been written Th

[GitHub] [camel-kafka-connector] orpiske commented on issue #27: Fix camel file test

2019-12-09 Thread GitBox
orpiske commented on issue #27: Fix camel file test URL: https://github.com/apache/camel-kafka-connector/pull/27#issuecomment-563263829 Please ignore. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [camel-kafka-connector] oscerd closed issue #18: Support Map and List as Headers

2019-12-09 Thread GitBox
oscerd closed issue #18: Support Map and List as Headers URL: https://github.com/apache/camel-kafka-connector/issues/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [camel-kafka-connector] oscerd merged pull request #26: Map list as headers

2019-12-09 Thread GitBox
oscerd merged pull request #26: Map list as headers URL: https://github.com/apache/camel-kafka-connector/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [camel-kafka-connector] oscerd opened a new pull request #26: Map list as headers

2019-12-09 Thread GitBox
oscerd opened a new pull request #26: Map list as headers URL: https://github.com/apache/camel-kafka-connector/pull/26 Fixes #18 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [camel-kafka-connector] oscerd closed issue #19: Add a CI job for PR

2019-12-09 Thread GitBox
oscerd closed issue #19: Add a CI job for PR URL: https://github.com/apache/camel-kafka-connector/issues/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [camel-kafka-connector] oscerd commented on issue #19: Add a CI job for PR

2019-12-09 Thread GitBox
oscerd commented on issue #19: Add a CI job for PR URL: https://github.com/apache/camel-kafka-connector/issues/19#issuecomment-563168214 This should be done with Github actions This is an automated message from the Apache Git

[GitHub] [camel-kafka-connector] oscerd opened a new issue #25: Integrations tests fails if confluentinc/cp-kafka:5.2.1 has not been pulled

2019-12-09 Thread GitBox
oscerd opened a new issue #25: Integrations tests fails if confluentinc/cp-kafka:5.2.1 has not been pulled URL: https://github.com/apache/camel-kafka-connector/issues/25 if one do a `mvn clean verify package` without having pulled `confluentinc/cp-kafka:5.2.1` this is the result: ``

[GitHub] [camel-kafka-connector] oscerd opened a new issue #24: Test code cleanups: embedded connect runtime improvements

2019-12-09 Thread GitBox
oscerd opened a new issue #24: Test code cleanups: embedded connect runtime improvements URL: https://github.com/apache/camel-kafka-connector/issues/24 I think we could investigate if we can cleanup the tests (re)using the work from: https://issues.apache.org/jira/browse/KAFKA-7503

[GitHub] [camel-kafka-connector] oscerd opened a new issue #23: Add a Camel like DSL to translate between DSL and properties

2019-12-09 Thread GitBox
oscerd opened a new issue #23: Add a Camel like DSL to translate between DSL and properties URL: https://github.com/apache/camel-kafka-connector/issues/23 If we have all the components together, I thought that we can add a DSL that is very similar to Camel DSL, that is to make it easier fo

[GitHub] [camel-kafka-connector] oscerd opened a new issue #21: Allow to bridge between Camel DataFormat and Kafka Connect SMT

2019-12-09 Thread GitBox
oscerd opened a new issue #21: Allow to bridge between Camel DataFormat and Kafka Connect SMT URL: https://github.com/apache/camel-kafka-connector/issues/21 It will be nice if we can somehow bridge between whetever we have for Camel DataFormat and bridge it as Kafka SMT (Single Message Tra

[GitHub] [camel-kafka-connector] oscerd opened a new issue #22: Allow to bridge between user's custom Camel Processor and Kafka Connect SMT

2019-12-09 Thread GitBox
oscerd opened a new issue #22: Allow to bridge between user's custom Camel Processor and Kafka Connect SMT URL: https://github.com/apache/camel-kafka-connector/issues/22 If the user has custom Camel Processor, IMHO it will be nice to bridge them into Kafka Connect as an SMT wrapper, where

[GitHub] [camel-kafka-connector] oscerd opened a new issue #20: Allow the user to set the key of the SourceRecord explicitly

2019-12-09 Thread GitBox
oscerd opened a new issue #20: Allow the user to set the key of the SourceRecord explicitly URL: https://github.com/apache/camel-kafka-connector/issues/20 Currently, when the messages being polled, via this method: ``` SourceRecord record = new SourceRecord(sourcePartition, sourceOffs

[GitHub] [camel-kafka-connector] oscerd opened a new issue #19: Add a CI job for PR

2019-12-09 Thread GitBox
oscerd opened a new issue #19: Add a CI job for PR URL: https://github.com/apache/camel-kafka-connector/issues/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [camel-kafka-connector] oscerd opened a new issue #18: Support Map and List as Headers

2019-12-09 Thread GitBox
oscerd opened a new issue #18: Support Map and List as Headers URL: https://github.com/apache/camel-kafka-connector/issues/18 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [camel-kafka-connector] oscerd opened a new issue #17: Find a better way of using sourcePartition and sourceOffset

2019-12-09 Thread GitBox
oscerd opened a new issue #17: Find a better way of using sourcePartition and sourceOffset URL: https://github.com/apache/camel-kafka-connector/issues/17 https://github.com/jboss-fuse/camel-kafka-connector/blob/master/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java#

[GitHub] [camel-kafka-connector] oscerd opened a new issue #16: support camel type converters

2019-12-09 Thread GitBox
oscerd opened a new issue #16: support camel type converters URL: https://github.com/apache/camel-kafka-connector/issues/16 Provide a way to support camel type converters and/or integrating them in kafka connect `key.converter` and `value.converter`. comment 1 @omarsmak: Hello @valda

[GitHub] [camel-kafka-connector] oscerd opened a new issue #15: Find a way to manage dependencies

2019-12-09 Thread GitBox
oscerd opened a new issue #15: Find a way to manage dependencies URL: https://github.com/apache/camel-kafka-connector/issues/15 In order to support camel components, the proper dependencies must be in the classpath. Decide a way to do it, there are some alternatives: - trivial option

[GitHub] [camel-kafka-connector] oscerd merged pull request #14: Setting up POM as ASF standard

2019-12-09 Thread GitBox
oscerd merged pull request #14: Setting up POM as ASF standard URL: https://github.com/apache/camel-kafka-connector/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [camel-kafka-connector] oscerd opened a new pull request #14: Setting up POM as ASF standard

2019-12-09 Thread GitBox
oscerd opened a new pull request #14: Setting up POM as ASF standard URL: https://github.com/apache/camel-kafka-connector/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log