Re: Remove the "jdk9+-build" maven profile?

2020-04-15 Thread Claus Ibsen
On Thu, Apr 16, 2020 at 8:05 AM Zheng Feng wrote: > > will we target for building camel with jdk-11 ? > Yes later this year we will drop JDK8 - current plan is after the 1st LTS release, eg Camel 3.4 LTS release, then Camel 3.5 is JDK11 onwards. > On Thu, Apr 16, 2020 at 1:28 PM Claus Ibsen wro

Re: Remove the "jdk9+-build" maven profile?

2020-04-15 Thread Zheng Feng
will we target for building camel with jdk-11 ? On Thu, Apr 16, 2020 at 1:28 PM Claus Ibsen wrote: > I created a ticket > https://issues.apache.org/jira/browse/CAMEL-14917 > > On Thu, Apr 16, 2020 at 7:11 AM Claus Ibsen wrote: > > > > Hi > > > > Yeah lets take a look at that. Its some old cruft

Re: Merge Commits?

2020-04-15 Thread David Jencks
Hi Claus, I think that sometimes more than one commit is appropriate for a PR. For instance some of mine recently have consisted of a few lines change of generation code and hundreds of files changed as a result. It’s much clearer if those are two separate commits. Also, my impression is tha

Re: Remove the "jdk9+-build" maven profile?

2020-04-15 Thread Claus Ibsen
I created a ticket https://issues.apache.org/jira/browse/CAMEL-14917 On Thu, Apr 16, 2020 at 7:11 AM Claus Ibsen wrote: > > Hi > > Yeah lets take a look at that. Its some old cruft from the early JDK9 days. > > On Wed, Apr 15, 2020 at 9:03 PM Pascal Schumacher > wrote: > > > > Hi, > > > > what d

Re: Remove the "jdk9+-build" maven profile?

2020-04-15 Thread Claus Ibsen
Hi Yeah lets take a look at that. Its some old cruft from the early JDK9 days. On Wed, Apr 15, 2020 at 9:03 PM Pascal Schumacher wrote: > > Hi, > > what do you think about removing the "jdk9+-build" profile in the parent > pom which adds a lot of JAXB/SOAP etc. related dependencies? > > When I r

Re: [Website] Possibility to generate component, data format, languages index tables

2020-04-15 Thread Claus Ibsen
Hi David Yeah its an improvement and thank for the core vs non-core components. On Wed, Apr 15, 2020 at 11:37 PM David Jencks wrote: > > I’ve supplied PRs for CAMEL-14906 > and CAMEL-14907 >

Re: Merge Commits?

2020-04-15 Thread Claus Ibsen
Hi Yes we should do rebase and merge, or squash and merge style, so its linear. On github the green button is default for "squash and merge". I always do git pull --rebase from CLI before pushing, so my commits are added on top of the branch. On Wed, Apr 15, 2020 at 10:09 PM Pascal Schumacher

Re: Merge Commits?

2020-04-15 Thread Tadayoshi Sato
+1 for avoiding merge commits in favour of linear history. While undocumented, I learned it on the job by reading the commit history which is mostly linear except developing big feature branches like the major upgrade. Of course, it would be better if the policy is documented clearly somewhere. A

Re: Merge Commits?

2020-04-15 Thread David Jencks
I’m in favor of changing the GitHub camel repositories to enforce rebase-and-merge: Rebasing and merging your commits . This will produce linear history. IIUC, the com

Re: [Website] Possibility to generate component, data format, languages index tables

2020-04-15 Thread David Jencks
I’ve supplied PRs for CAMEL-14906 and CAMEL-14907 . I put up a preview showing both these changes: https://camel-preview-1.s3-us-west-2.amazonaws.com/manual/latest/index.html#_components_data_

Re: Merge Commits?

2020-04-15 Thread Andrea Cosentino
I don't think there is a consensus around this.. we can collect here the different views. Personally I don't think merge commits are evil, but if a clean history is desired it's fine for me Il mer 15 apr 2020, 22:09 Pascal Schumacher ha scritto: > Hi, > > recently there were several merge commi

Re: Merge Commits?

2020-04-15 Thread Omar Al-Safi
Sorry I wasn't aware of such thing, do we have some guidelines regarding this? I don't recall I came through this. Perhaps, we can add a page of guidelines and tips for committers to follow? I think Camel has grown and with it the amount of committers have grown which is a good thing of course. Re

Re: Merge Commits?

2020-04-15 Thread David Jencks
I’m a bit unclear on terms and actions. If you have a PR on GitHub that is up to date with master and you press the “merge” button do you get a merge commit? I’m definitely against anything that results in non-linear history on a branch, and would support anything that enforces this. I’ve look

Merge Commits?

2020-04-15 Thread Pascal Schumacher
Hi, recently there were several merge commits (especially for merged pull request). I thought the consensus was to avoid merge commits to keep the git history as clean as possible. Should we keep this policy? What do you think? Cheers, Pascal

Remove the "jdk9+-build" maven profile?

2020-04-15 Thread Pascal Schumacher
Hi, what do you think about removing the "jdk9+-build" profile in the parent pom which adds a lot of JAXB/SOAP etc. related dependencies? When I remove this profile and try to build on Java I get no further than the "camel-api" module: [ERROR] /camel/core/camel-api/src/main/java/org/apache/came

Re: [ROADMAP] - Apache Camel 3.3

2020-04-15 Thread Claus Ibsen
On Wed, Apr 15, 2020 at 9:55 AM Omar Al-Safi wrote: > > +1 > > By the way, isn't the plan on June per this blog > ? > From my side, I( will try to get as many azurev12 components as possible > into 3.3 release. > That blog post was subject for

Re: [ROADMAP] - Apache Camel 3.3

2020-04-15 Thread Guillaume Nodet
Le mer. 15 avr. 2020 à 07:28, Claus Ibsen a écrit : > Hi > > Lets keep the momentum going and release a new 3.x version next month. > And lets aim for 3 weeks time. So if we can get Camel 3.3 released in > start of / mid May 2020, then that would be great. > > Here are some of the areas to work o

Re: [ROADMAP] - Apache Camel 3.3

2020-04-15 Thread Omar Al-Safi
+1 By the way, isn't the plan on June per this blog ? >From my side, I( will try to get as many azurev12 components as possible into 3.3 release. Regards, Omar On Wed, Apr 15, 2020 at 8:11 AM Jean-Baptiste Onofre wrote: > +1 > > I will work