[DISCUSS] - camel-websocket component

2012-06-11 Thread Claus Ibsen
Hi In Camel 2.10 we introduce a new component: camel-websocket. Its currently based on Jetty, and thus requires jetty to be used. In recent time the component was enhanced to support SSL with websocket as well. That change brings in a lot of code that was copied directly from the existing camel-j

Re: [DISCUSS] - camel-websocket component

2012-06-11 Thread Charles Moulliard
Hi Claus, I completely agree on your proposition as we reuse pieces of code between the different (same) camel components (jetty, websocket but also cometd) as they increase "maintenance" costs. Point 1) --> +1 to merge camel-jetty, camel-websocket and camel-cometd The most important thing will

Re: [DISCUSS] - camel-websocket component

2012-06-11 Thread Daniel Kulp
This does make a lot of sense to me. websocket is really a standard for which there could be multiple implementations. Thus, the component name really should be the implementation, not the standard. Otherwise you get into the whole "camel-http" issue again of having multiple things that CO

Re: [DISCUSS] - camel-websocket component

2012-06-12 Thread Christian Müller
+1 from my point of view. Christian Sent from a mobile device Am 11.06.2012 18:52 schrieb "Daniel Kulp" : > > This does make a lot of sense to me. websocket is really a standard for > which there could be multiple implementations. Thus, the component name > really should be the implementation

Re: [DISCUSS] - camel-websocket component

2012-06-12 Thread Johan Edstrom
+1 On Jun 12, 2012, at 3:56 PM, Christian Müller wrote: > +1 from my point of view. > > Christian > > Sent from a mobile device > Am 11.06.2012 18:52 schrieb "Daniel Kulp" : > >> >> This does make a lot of sense to me. websocket is really a standard for >> which there could be multiple imp

Re: [DISCUSS] - camel-websocket component

2012-06-12 Thread Jean-Baptiste Onofré
+1 Regards JB On 06/11/2012 11:38 AM, Claus Ibsen wrote: Hi In Camel 2.10 we introduce a new component: camel-websocket. Its currently based on Jetty, and thus requires jetty to be used. In recent time the component was enhanced to support SSL with websocket as well. That change brings in a l

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Claus Ibsen
Hi I have logged a ticket about this https://issues.apache.org/jira/browse/CAMEL-5364 I don't think we got the time to work on this now. So I have scheduled it for 2.11. Also I can see that camel-websocket needs to mature a bit more, for example the last commit by Charles is a bit "hacky". And I

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Babak Vahdat
being commented out: org.apache.camel.component.websocket.WebsocketComponentTest which is a bit "ugly" as well. If no volunteer, I could try to fix them but not before this weekend. Babak -- View this message in context: http://camel.465427.n5.nabble.com/DISCUSS-camel-websocket-co

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Charles Moulliard
ll. If no volunteer, I could try to fix them but > not before this weekend. > > Babak > > > -- > View this message in context: > http://camel.465427.n5.nabble.com/DISCUSS-camel-websocket-component-tp5714283p5714404.html > Sent from the Camel Development mailing list archive at Nabble.com. >

Re: [DISCUSS] - camel-websocket component

2012-06-13 Thread Babak Vahdat
I could try to fix them >> but >> not before this weekend. >> >> Babak >> >> >> -- >> View this message in context: >> http://camel.465427.n5.nabble.com/DISCUSS-camel-websocket-component-tp5714283p5714404.html >> Sent from the Camel Development mailing list archive at Nabble.com. >> > -- View this message in context: http://camel.465427.n5.nabble.com/DISCUSS-camel-websocket-component-tp5714283p5714450.html Sent from the Camel Development mailing list archive at Nabble.com.