Re: [DISCUSS] Refactoring of Registry/Injector interface

2013-01-23 Thread Claus Ibsen
Hi On Tue, Jan 22, 2013 at 4:58 PM, Claus Ibsen wrote: > Hi > > I logged a ticket to not forget about this. > https://issues.apache.org/jira/browse/CAMEL-5997 > > Will work with Lukasz proposals to get this into the 2.11 codebase, so > we have a baseline for better CDI and OSGi registry integrati

Re: [DISCUSS] Refactoring of Registry/Injector interface

2013-01-22 Thread Claus Ibsen
Hi I logged a ticket to not forget about this. https://issues.apache.org/jira/browse/CAMEL-5997 Will work with Lukasz proposals to get this into the 2.11 codebase, so we have a baseline for better CDI and OSGi registry integration. On Tue, Nov 20, 2012 at 6:16 PM, Łukasz Dywicki wrote: > Dear

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-23 Thread Charles Moulliard
I think that we need at least one more to be able to find interface registered in OSGI registry but using the filter. In this class, we need Class and filter lookupByTypeAndFilter(Class type, String Filter) On Fri, Nov 23, 2012 at 8:18 AM, Claus Ibsen wrote: > On Thu, Nov 22, 2012 at 9:51 PM,

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-22 Thread Claus Ibsen
On Thu, Nov 22, 2012 at 9:51 PM, Christian Müller wrote: > +1 > I'm fine with this changes. I'm only wondering what is the intention for > "lookupByNameAndType"? Throwing an exception if the type is different? Or > returning null? Or ...? > I also suggest cutting down on the number of methods. Cu

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-22 Thread David Karlsen
I suggest looking at the spring api for some sensible behaviours. Den 22. nov. 2012 21:52 skrev "Christian Müller" < christian.muel...@gmail.com> følgende: > > +1 > I'm fine with this changes. I'm only wondering what is the intention for > "lookupByNameAndType"? Throwing an exception if the type is

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-22 Thread Christian Müller
+1 I'm fine with this changes. I'm only wondering what is the intention for "lookupByNameAndType"? Throwing an exception if the type is different? Or returning null? Or ...? Best, Christian On Tue, Nov 20, 2012 at 6:16 PM, Łukasz Dywicki wrote: > Dear all, > During my work on camel-cdi componen

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-20 Thread Claus Ibsen
On Wed, Nov 21, 2012 at 2:25 AM, Hadrian Zbarcea wrote: > Sounds good to me, not sure in what release it would make sense to make this > change. One comment, there is no reason for lookupByNameAndType to not be > called simply lookupByName (name override). The findByTypeWithName method > name is a

Re: [DISCUSS] Refactoring of Registry/Injector interface

2012-11-20 Thread Hadrian Zbarcea
Sounds good to me, not sure in what release it would make sense to make this change. One comment, there is no reason for lookupByNameAndType to not be called simply lookupByName (name override). The findByTypeWithName method name is a bit ugly too, imho. I'll think about it some more, Hadrian