> @SuppressWarnings("rawtypes")
> > > JSONProvider jsonProvider = new JSONProvider();
> > >
> > > We could better do:
> > >
> > > JSONProvider
>
>
> > jsonProvider = new JSONProvider
>
> > ();
> > >
> > > - There's no benefit of the following generic List type newly introduced
> > > by the API:
> > >
> > > public void setProviders(List providers)...
> > >
> > > As is as good as so maybe better do:
> > >
> > > public void setProviders(List providers)...
> > >
> > > See http://docs.oracle.com/javase/specs/jls/se7/html/jls-4.html#jls-4.4
> > >
> > > ...Every type variable declared as a type parameter has a bound. If no
> > > bound is declared for a type variable, Object is assumed.
> > >
> > > Babak
>
>
>
>
>
>
> --
> View this message in context:
> http://camel.465427.n5.nabble.com/About-2-commits-of-today-tp5743462p5743486.html
> Sent from the Camel Development mailing list archive at Nabble.com
> (http://Nabble.com).
uot;rawtypes")
>> JSONProvider jsonProvider = new JSONProvider();
>>
>> We could better do:
>>
>> JSONProvider
> jsonProvider = new JSONProvider
> ();
>>
>> - There's no benefit of the following generic List type newly introduced
>
For what is worth, the test was failing with all JDKs not just OpenJDK.
Not sure if hardcoding the cipher suite is the best fix in the long run,
but it does work.
Hadrian
On 11/18/2013 09:56 PM, Willem jiang wrote:
Hi Babak,
Thanks for the review, I just updated the code with some suggestio
Hi Babak,
Thanks for the review, I just updated the code with some suggestion of you.
For the SSLContextParametersTest it is caused by the different JDKs handles the
SSL related setting differently, I just updated the code to avoid the null
collection returned.
--
Willem Jiang
Red Hat, Inc.
Good catch Babak. Thanks,
Hadrian
On 11/18/2013 02:59 PM, Babak Vahdat wrote:
Hi
Just spotted couple of things on the commit mailing list of today:
http://git-wip-us.apache.org/repos/asf/camel/diff/000581e6
This commit now makes the following asserts passing:
assertStartsWith((String[]) n
Hi
Just spotted couple of things on the commit mailing list of today:
http://git-wip-us.apache.org/repos/asf/camel/diff/000581e6
This commit now makes the following asserts passing:
assertStartsWith((String[]) null, "foo");
assertStartsWith(new String[] {}, "foo");
assertStartsWith((Colle
