As it does not make any effective difference, I've removed final for
consistency across components.
Thx,
Luca
---
Luca Burgazzoli
On Tue, May 10, 2016 at 5:51 PM, Matt Sicker wrote:
> I personally wouldn't extend it (I use camel-hazelcast for caching), but
> I'm just looking at consistency wi
Hi Babak,
1) Yes it makes sense, https://issues.apache.org/jira/browse/CAMEL-9956
2) Fixed by the latest commit
Regards,
Luca
---
Luca Burgazzoli
On Tue, May 10, 2016 at 6:49 PM, Babak Vahdat
wrote:
> Hi Luca,
>
> Very well done! Just 2 tiny remarks:
>
> - Wonder if it would make sense to mov
Hi Luca,
Very well done! Just 2 tiny remarks:
- Wonder if it would make sense to move the FluentProducerTemplate usage of
EhcacheTestSupport up to CamelTestSupport, so others (Camel's own tests as
well as Camel user's tests) could benefit from it if wished, like the
CamelTestSupport#template prop
I personally wouldn't extend it (I use camel-hazelcast for caching), but
I'm just looking at consistency with the rest of the camel components. Do
you think more components should follow this pattern, or is the ehcache one
an exception?
On 10 May 2016 at 10:17, Luca Burgazzoli wrote:
> Yep, I've
Yep, I've added it to enforce the idea that the producer/consumer are
not supposed to be extended (imho, the should also be package private)
but no problem to remove them, could you raise a JIRA if you think
final should be removed ?
---
Luca Burgazzoli
On Tue, May 10, 2016 at 5:02 PM, Matt Sicke
Not necessarily, but I don't see other components using final like that.
On 10 May 2016 at 09:19, Luca Burgazzoli wrote:
> Not mandatory but are component's consumer/producer supposed to be
> extended ?
> ---
> Luca Burgazzoli
>
>
> On Tue, May 10, 2016 at 4:05 PM, Matt Sicker wrote:
> > Do Ehc
Not mandatory but are component's consumer/producer supposed to be extended ?
---
Luca Burgazzoli
On Tue, May 10, 2016 at 4:05 PM, Matt Sicker wrote:
> Do EhcacheConsumer and EhcacheProducer have to be final?
>
> On 10 May 2016 at 08:18, Luca Burgazzoli wrote:
>
>> Hello,
>>
>> I've merged a fi
Do EhcacheConsumer and EhcacheProducer have to be final?
On 10 May 2016 at 08:18, Luca Burgazzoli wrote:
> Hello,
>
> I've merged a first cut of camel-ehcache
> (
> https://github.com/apache/camel/commit/9a473f3980f679b62a22fc6a191b54164ad38001
> )
> Let me know if you find something wrong or th
Hello,
I've merged a first cut of camel-ehcache
(https://github.com/apache/camel/commit/9a473f3980f679b62a22fc6a191b54164ad38001)
Let me know if you find something wrong or that could be improved.
---
Luca Burgazzoli
On Wed, Apr 20, 2016 at 7:52 AM, Andrea Cosentino
wrote:
> +1 :-)
> --
> An
+1 :-)
--
Andrea Cosentino
--
Apache Camel PMC Member
Apache Karaf Committer
Apache Servicemix Committer
Email: ancosen1...@yahoo.com
Twitter: @oscerd2
Github: oscerd
On Wednesday, April 20, 2016 7:41 AM, Luca Burgazzoli
wrote:
Yep, that was one of the main re
Yep, that was one of the main reasons :-)
---
Luca Burgazzoli
On Tue, Apr 19, 2016 at 11:10 PM, Bilgin Ibryam wrote:
> Good idea. Also may be we should name the component this time ehcache
> rather than just cache as we have many cache implementations.
>
> On 19 April 2016 at 17:17, Claus Ibsen
Good idea. Also may be we should name the component this time ehcache
rather than just cache as we have many cache implementations.
On 19 April 2016 at 17:17, Claus Ibsen wrote:
> On Tue, Apr 19, 2016 at 5:42 PM, Luca Burgazzoli
> wrote:
>> Hello,
>>
>> As Ehcache has released version 3.0 of th
On Tue, Apr 19, 2016 at 5:42 PM, Luca Burgazzoli wrote:
> Hello,
>
> As Ehcache has released version 3.0 of their caching solution
> (http://www.ehcache.org/) it may make sense to make a new component
> camel-ehcache and deprecating the old camel-cache component.
>
> Thoughts ?
>
Yeah that is a g
Hello,
As Ehcache has released version 3.0 of their caching solution
(http://www.ehcache.org/) it may make sense to make a new component
camel-ehcache and deprecating the old camel-cache component.
Thoughts ?
---
Luca Burgazzoli
14 matches
Mail list logo
