Re: HEADS-UP: maven profile changes

2022-05-02 Thread Jeremy Ross
Obviously it's best to not let improperly formatted code into the repo to begin with, but we can give this a try and see how it works out in practice. On Sun, May 1, 2022 at 1:35 PM Otavio Rodolfo Piske wrote: > Hello Jeremy, > > I agree with you that moving to a manual check of the format can

Re: HEADS-UP: maven profile changes

2022-05-01 Thread Otavio Rodolfo Piske
Hello Jeremy, I agree with you that moving to a manual check of the format can lead to more non-compliant code. To reduce this risk, I have reworked a Gtihub action that we had before, so that it automatically checks for code formatting violations [1]. If any formatting violation is found, then i

Re: HEADS-UP: maven profile changes

2022-04-30 Thread Jeremy Ross
I suspect that sorting/formatting by default was fairly effective at keeping the codebase compliant with standards. If a certain maven profile is required to format and/or sourcecheck, it seems that we'll end up with more non-compliant code. I know we're trying to speed up build times, so is there

HEADS-UP: maven profile changes

2022-04-26 Thread Otavio Rodolfo Piske
Hello, Just as a heads up, as part of the work on CAMEL-17894, there was a change in the plugins running by default on our build. Previously, the code would run the import sorting + code formatting by default. This behavior was now moved to the "format" profile. As such, to both format and run th