Re: Consul ServiceCall EIP

2016-06-07 Thread Claus Ibsen
On Tue, Jun 7, 2016 at 11:53 AM, Luca Burgazzoli wrote: > I've pushed some new code and polished the old one to my branch so now > we have service calls for: > > - camel-kubernetes > - camel-consul > - camel-etcd > - camel-dns > - camel-ribbon > > Ribbon work a little bit differently from the othe

Re: Consul ServiceCall EIP

2016-06-07 Thread Luca Burgazzoli
I've pushed some new code and polished the old one to my branch so now we have service calls for: - camel-kubernetes - camel-consul - camel-etcd - camel-dns - camel-ribbon Ribbon work a little bit differently from the others so it does make use of only a small subset of common base classes. Base

Re: Consul ServiceCall EIP

2016-06-01 Thread Claus Ibsen
Ah yeah it should, you are welcome to fix that. On Wed, Jun 1, 2016 at 3:11 PM, Luca Burgazzoli wrote: > I did had a look but as it does not use > KubernetesDnsServiceCallExpression I'm having hard times to figure out > how it works, shouldn't KubernetesDnsServiceCallExpression be used > instead

Re: Consul ServiceCall EIP

2016-06-01 Thread Luca Burgazzoli
I did had a look but as it does not use KubernetesDnsServiceCallExpression I'm having hard times to figure out how it works, shouldn't KubernetesDnsServiceCallExpression be used instead of KubernetesServiceCallExpression ? --- Luca Burgazzoli On Wed, Jun 1, 2016 at 2:54 PM, Claus Ibsen wrote: >

Re: Consul ServiceCall EIP

2016-06-01 Thread Claus Ibsen
On Wed, Jun 1, 2016 at 2:53 PM, Luca Burgazzoli wrote: > --- > Luca Burgazzoli > > > On Wed, Jun 1, 2016 at 2:44 PM, Luca Burgazzoli wrote: >> --- >> Luca Burgazzoli >> >> >> On Wed, Jun 1, 2016 at 9:13 AM, Luca Burgazzoli >> wrote: >>> Will fix them today >>> --- >>> Luca Burgazzoli >>> >>> >>

Re: Consul ServiceCall EIP

2016-06-01 Thread Claus Ibsen
On Wed, Jun 1, 2016 at 2:44 PM, Luca Burgazzoli wrote: > --- > Luca Burgazzoli > > > On Wed, Jun 1, 2016 at 9:13 AM, Luca Burgazzoli wrote: >> Will fix them today >> --- >> Luca Burgazzoli >> >> >> On Wed, Jun 1, 2016 at 8:56 AM, Claus Ibsen wrote: >>> Hi >>> >>> Looks good there is only a few s

Re: Consul ServiceCall EIP

2016-06-01 Thread Luca Burgazzoli
--- Luca Burgazzoli On Wed, Jun 1, 2016 at 2:44 PM, Luca Burgazzoli wrote: > --- > Luca Burgazzoli > > > On Wed, Jun 1, 2016 at 9:13 AM, Luca Burgazzoli wrote: >> Will fix them today >> --- >> Luca Burgazzoli >> >> >> On Wed, Jun 1, 2016 at 8:56 AM, Claus Ibsen wrote: >>> Hi >>> >>> Looks good

Re: Consul ServiceCall EIP

2016-06-01 Thread Luca Burgazzoli
--- Luca Burgazzoli On Wed, Jun 1, 2016 at 9:13 AM, Luca Burgazzoli wrote: > Will fix them today > --- > Luca Burgazzoli > > > On Wed, Jun 1, 2016 at 8:56 AM, Claus Ibsen wrote: >> Hi >> >> Looks good there is only a few spots I have some comments. >> >> - There is some code that has not null c

Re: Consul ServiceCall EIP

2016-06-01 Thread Luca Burgazzoli
Will fix them today --- Luca Burgazzoli On Wed, Jun 1, 2016 at 8:56 AM, Claus Ibsen wrote: > Hi > > Looks good there is only a few spots I have some comments. > > - There is some code that has not null check for load balancer / > server list strategy. The kubernetes component can do without that

Re: Consul ServiceCall EIP

2016-05-31 Thread Claus Ibsen
Hi Looks good there is only a few spots I have some comments. - There is some code that has not null check for load balancer / server list strategy. The kubernetes component can do without that when you use ENV or DNS as lookup. - There was a place where you do some logging and it says Consul wh

Re: Consul ServiceCall EIP

2016-05-31 Thread Luca Burgazzoli
I've committed some more code to my branch [2], it is not yet complete (i.e. I still have to make ribbon code to use the new common classes and some APIs are not clean enough) but a feedback would be really welcome. --- Luca Burgazzoli On Mon, May 30, 2016 at 10:55 AM, Claus Ibsen wrote: > On M

Re: Consul ServiceCall EIP

2016-05-30 Thread Claus Ibsen
On Mon, May 30, 2016 at 10:49 AM, Luca Burgazzoli wrote: > So like serviceCall("myServiceCall").configurationRef("myConf") ? Yeah there is already a DSL for that named serviceCallConfiguration("myConf") > --- > Luca Burgazzoli > > > On Mon, May 30, 2016 at 10:26 AM, Claus Ibsen wrote: >> On

Re: Consul ServiceCall EIP

2016-05-30 Thread Luca Burgazzoli
So like serviceCall("myServiceCall").configurationRef("myConf") ? --- Luca Burgazzoli On Mon, May 30, 2016 at 10:26 AM, Claus Ibsen wrote: > On Mon, May 30, 2016 at 10:16 AM, Luca Burgazzoli > wrote: >> do you mean something like serviceCallRef("myServiceCall") ? >> --- > > No you need to prov

Re: Consul ServiceCall EIP

2016-05-30 Thread Claus Ibsen
On Mon, May 30, 2016 at 10:16 AM, Luca Burgazzoli wrote: > do you mean something like serviceCallRef("myServiceCall") ? > --- No you need to provide - a) name of service to call - b) reference to configuration of service a = mandatory b = optional. As if there is only 1 configuration then use t

Re: Consul ServiceCall EIP

2016-05-30 Thread Luca Burgazzoli
do you mean something like serviceCallRef("myServiceCall") ? --- Luca Burgazzoli On Sun, May 29, 2016 at 9:42 AM, Claus Ibsen wrote: > On Thu, May 26, 2016 at 7:30 PM, Luca Burgazzoli > wrote: >> --- >> Luca Burgazzoli >> >> >> On Thu, May 26, 2016 at 7:06 PM, Claus Ibsen wrote: >>> Hi Luca >

Re: Consul ServiceCall EIP

2016-05-29 Thread Claus Ibsen
On Thu, May 26, 2016 at 7:30 PM, Luca Burgazzoli wrote: > --- > Luca Burgazzoli > > > On Thu, May 26, 2016 at 7:06 PM, Claus Ibsen wrote: >> Hi Luca >> >> Yeah its good to get more eyes on this new set of code. When I created >> kubernetes and ribbon there was sure some overlap of code that could

Re: Consul ServiceCall EIP

2016-05-26 Thread Luca Burgazzoli
--- Luca Burgazzoli On Thu, May 26, 2016 at 7:06 PM, Claus Ibsen wrote: > Hi Luca > > Yeah its good to get more eyes on this new set of code. When I created > kubernetes and ribbon there was sure some overlap of code that could > be shared, but I didn't push for much default/abstract code in > c

Re: Consul ServiceCall EIP

2016-05-26 Thread Claus Ibsen
Hi Luca Yeah its good to get more eyes on this new set of code. When I created kubernetes and ribbon there was sure some overlap of code that could be shared, but I didn't push for much default/abstract code in camel-core because there its new code and I also wanted to see what consul, etcd, zooke