Re: camel git commit: CAMEL-10915 Add type conversion support for jav...

2017-03-01 Thread Claus Ibsen
Hi That sounds like a fine use-case. +1 On Wed, Mar 1, 2017 at 1:11 PM, Zoran Regvart wrote: > Hi, > On Wed, Mar 1, 2017 at 1:04 PM, Claus Ibsen wrote: >> >> But is there something about creating URI is expensive? I vaguely >> recall something about creating either that or URL that may do some

Re: camel git commit: CAMEL-10915 Add type conversion support for jav...

2017-03-01 Thread Zoran Regvart
Hi, On Wed, Mar 1, 2017 at 1:04 PM, Claus Ibsen wrote: > > But is there something about creating URI is expensive? I vaguely > recall something about creating either that or URL that may do some > hostname lookup or something. java.net.URL is the evil blocking one it blocks in hashCode on DNS loo

Re: camel git commit: CAMEL-10915 Add type conversion support for jav...

2017-03-01 Thread Claus Ibsen
Hi That kind is fine. You should avoid using Object. As long as the from -> to are specific types and not open ended like Object. The latter requests to use a fallback type converter and some more "tricky" code to do this correctly. But is there something about creating URI is expensive? I vaguel

Re: camel git commit: CAMEL-10915 Add type conversion support for jav...

2017-03-01 Thread Zoran Regvart
Hi Claus, thanks for reviewing :) Would this be better? CharSequence toCharSequence(URI value) and URI toUri(CharSequence value) or do you think that URI type converter support should be removed entirely? zoran On Wed, Mar 1, 2017 at 12:29 PM, Claus Ibsen wrote: > On Wed, Mar 1, 2017 at 12:2

Re: camel git commit: CAMEL-10915 Add type conversion support for jav...

2017-03-01 Thread Claus Ibsen
On Wed, Mar 1, 2017 at 12:21 PM, wrote: > Repository: camel > Updated Branches: > refs/heads/master c6a15565a -> d569b80d8 > > > CAMEL-10915 Add type conversion support for jav... > > ...a.net.URI > > Adds converter to and from `java.net.URI` and `java.lang.CharSequence`. > > > Project: http://