Fwd: Re: svn commit: r1164515 - /camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/PropertyEditorTypeConverter.java

2011-09-02 Thread Hadrian Zbarcea
Moving to dev@. -1. Please revert your change and let's fix it properly. In the future please do not revert my changes without discussing that with me, even if you believe it's the right thing to do. The PropertyEditoryTypeConverter and being a Service and leaks are two separate issues.

Re: Re: svn commit: r1164515 - /camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/PropertyEditorTypeConverter.java

2011-09-02 Thread Claus Ibsen
On Fri, Sep 2, 2011 at 4:50 PM, Hadrian Zbarcea hzbar...@gmail.com wrote: Moving to dev@. -1. Please revert your change and let's fix it properly. In the future please do not revert my changes without discussing that with me, even if  you believe it's the right thing to do. The

Re: Re: svn commit: r1164515 - /camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/PropertyEditorTypeConverter.java

2011-09-02 Thread Claus Ibsen
Okay I got a bit upset here. But I cant understand why you want to turn the blind eye to the fact you introduced a leak, despite being careful. What is the problem with that class being a service, which then have callbacks (start/stop) where it can ensure the cache is cleared when stopping. What