Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2013-01-01 Thread Claus Ibsen
On Mon, Dec 31, 2012 at 9:52 AM, Willem jiang wrote: > > > On Saturday, December 29, 2012 at 6:38 PM, Claus Ibsen wrote: > >> On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang > (mailto:willem.ji...@gmail.com)> wrote: >> > The CamelSpringTestSupport is marked as @deprecated already, it will be >> > r

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-31 Thread Willem jiang
On Saturday, December 29, 2012 at 6:38 PM, Claus Ibsen wrote: > On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang (mailto:willem.ji...@gmail.com)> wrote: > > The CamelSpringTestSupport is marked as @deprecated already, it will be > > removed in Camel 3.0. > > > > Ah yeah it has been @depreca

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-29 Thread Claus Ibsen
On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang wrote: > The CamelSpringTestSupport is marked as @deprecated already, it will be > removed in Camel 3.0. Ah yeah it has been @deprecated for a rather long time (eg junit 3.x support). In light of this we could consider to - remove junit 3.x support i

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
On Fri, Dec 28, 2012 at 2:06 PM, Willem jiang wrote: > The CamelSpringTestSupport is marked as @deprecated already, it will be > removed in Camel 3.0. Okay so we have already prepared for that. > I think ExcludingPackageScanClassResolver can be move to camel-test as it has > no other dependency

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Willem jiang
The CamelSpringTestSupport is marked as @deprecated already, it will be removed in Camel 3.0. I think ExcludingPackageScanClassResolver can be move to camel-test as it has no other dependency of Spring. -- Willem Jiang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://www.fusesourc

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang wrote: > It looks like we need to put the CamelSpringTestSupport and > ExcludingPackageScanClassResolver to the camel-test to avoid exporting the > package of org.apache.camel.test. > > Any suggestion ? Maybe a better solution could be to copy the

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Willem jiang
OK, I'd like to revert the change and add some note on the camel release. Even camel-test-spring has the classes from camel-test, it has no negative effect, we just need to let user know if he wants to use camel-test-spring in osgi, he should avoid install camel-test bundle. -- Willem Jiang

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang wrote: > It looks like we need to put the CamelSpringTestSupport and > ExcludingPackageScanClassResolver to the camel-test to avoid exporting the > package of org.apache.camel.test. > -1 We cannot have spring dependency in camel-test. And the clas

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Willem jiang
User may run unit tests with pax-exam which could need to install the bundle of camel-test and camel-test-spring. It will have some trouble when camel-test and camel-test-spring export the same package of org.apache.camel.test. -- Willem Jiang Red Hat, Inc. FuseSource is now part of Red Hat

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
Well I think camel-test, camel-test-spring, camel-test-xxx should not be OSGi bundles. Then we dont have issue with the bundle plugin packing the JARs wrong! On Fri, Dec 28, 2012 at 11:03 AM, Claus Ibsen wrote: > Why not rever the change. The old code worked fine. > > On Fri, Dec 28, 2012 at 10:4

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
Why not rever the change. The old code worked fine. On Fri, Dec 28, 2012 at 10:47 AM, Willem jiang wrote: > It looks like we need to put the CamelSpringTestSupport and > ExcludingPackageScanClassResolver to the camel-test to avoid exporting the > package of org.apache.camel.test. > > Any sugges

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Willem jiang
It looks like we need to put the CamelSpringTestSupport and ExcludingPackageScanClassResolver to the camel-test to avoid exporting the package of org.apache.camel.test. Any suggestion ? -- Willem Jiang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://www.fusesource.com | http://ww

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Willem jiang
Hi Claus, Thanks for pointing that out. I will commit the fix shortly. -- Willem Jiang Red Hat, Inc. FuseSource is now part of Red Hat Web: http://www.fusesource.com | http://www.redhat.com Blog: http://willemjiang.blogspot.com (http://willemjiang.blogspot.com/) (English) http://j

Re: svn commit: r1426385 - /camel/trunk/components/camel-test-spring/pom.xml

2012-12-28 Thread Claus Ibsen
Hi I think something broke camel-testng (eg TestNG). This morning I get this compilation error with latest code [INFO] [INFO] BUILD FAILURE [INFO] [INF