Re: SMPP changes: ordering the pull requests

2014-12-04 Thread Willem Jiang
Hi Claus, Thanks for you help. -- Willem Jiang Red Hat, Inc. Web: http://www.redhat.com Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On December 3, 2014 at 10:53:52 PM, Claus Ibsen (claus.ib...@gmail.com) wrote: > Hi >

Re: SMPP changes: ordering the pull requests

2014-12-04 Thread Claus Ibsen
Hi Thanks for the help with camel-smpp. And yeah know you know the drill, so future PRs is welcome. On Wed, Dec 3, 2014 at 8:22 PM, Daniel Pocock wrote: > > > On 03/12/14 16:34, Daniel Pocock wrote: >> On 03/12/14 15:52, Claus Ibsen wrote: >>> Hi >>> >>> Thanks that is a good plan. >>> >>> I th

Re: SMPP changes: ordering the pull requests

2014-12-04 Thread Claus Ibsen
On Wed, Dec 3, 2014 at 3:43 PM, Daniel Pocock wrote: > > > I suggest merging in the following order. As each one is merged, I'll > update the next one to merge cleanly with master. Please email me or > comment in Github when each of them is accepted. > > > https://github.com/apache/camel/pull/32

Re: SMPP changes: ordering the pull requests

2014-12-04 Thread Daniel Pocock
On 03/12/14 16:34, Daniel Pocock wrote: > On 03/12/14 15:52, Claus Ibsen wrote: >> Hi >> >> Thanks that is a good plan. >> >> I think Willem is buys with some work issues. >> So let me jump in when I am finished with CAMEL-8086 > > Thanks. If you already started looking at CAMEL-8116 please not

Re: SMPP changes: ordering the pull requests

2014-12-03 Thread Daniel Pocock
On 03/12/14 15:52, Claus Ibsen wrote: > Hi > > Thanks that is a good plan. > > I think Willem is buys with some work issues. > So let me jump in when I am finished with CAMEL-8086 Thanks. If you already started looking at CAMEL-8116 please note I have just updated it again with unit tests and a b

Re: SMPP changes: ordering the pull requests

2014-12-03 Thread Claus Ibsen
Hi Thanks that is a good plan. I think Willem is buys with some work issues. So let me jump in when I am finished with CAMEL-8086 On Wed, Dec 3, 2014 at 3:43 PM, Daniel Pocock wrote: > > > I suggest merging in the following order. As each one is merged, I'll > update the next one to merge clea

SMPP changes: ordering the pull requests

2014-12-03 Thread Daniel Pocock
I suggest merging in the following order. As each one is merged, I'll update the next one to merge cleanly with master. Please email me or comment in Github when each of them is accepted. https://github.com/apache/camel/pull/321 https://issues.apache.org/jira/browse/CAMEL-8008 (should