Re: Support of official commons-csv

2014-11-24 Thread Antoine DESSAIGNE
Hi everyone, This weekend commons-csv 1.1 was released, thus I've updated the pull-request with the latest version. Have a nice day, Antoine. 2014-11-07 18:39 GMT+01:00 Antoine DESSAIGNE : > Hi everyone, > > Since it's a pretty big pull-request, I'm going to explain the changes > I've made and

Re: Support of official commons-csv

2014-11-07 Thread Antoine DESSAIGNE
Hi everyone, Since it's a pretty big pull-request, I'm going to explain the changes I've made and the reasons for them. The most obvious change is the model of commons-csv. Previously, commons-csv was using 2 objects, a CSVStrategy and a CSVConfig, that we configured using a getter/setter approac

Re: Support of official commons-csv

2014-11-05 Thread Claus Ibsen
Hi Thanks. I think its a good time to migrate this in Camel 2.15. But the PR has merge conflicts now. Do you mind rebasing so the PR can be merged on master branch? On Wed, Oct 15, 2014 at 12:10 PM, Antoine DESSAIGNE wrote: > Hi everyone, > > I've submitted this PR https://github.com/apache/ca

Re: Support of official commons-csv

2014-10-15 Thread Antoine DESSAIGNE
Hi everyone, I've submitted this PR https://github.com/apache/camel/pull/292 for updating csv to the official version What do you think ? Have a nice day. Antoine. 2014-09-12 11:59 GMT+02:00 Antoine DESSAIGNE : > Hi, > > I don't see how it can be compatible since the public API of CsvDataForm

Re: Support of official commons-csv

2014-09-12 Thread Antoine DESSAIGNE
Hi, I don't see how it can be compatible since the public API of CsvDataFormat relies on 2 classes that were deleted : CSVStrategy and CSVConfig. I'm also not convinced by a camel-csv2 component since it's common-csv version 1. I would rather have another component ("camel-csv-commons" ?) that pu

Re: Support of official commons-csv

2014-09-11 Thread Christian Müller
+1 I think a camel-csv2 component is not necessary. Best, Christian - Software Integration Specialist Apache Member V.P. Apache Camel | Apache Camel PMC Member | Apache Camel committer Apache Incubator PMC Member https://www.linkedin.com/pub/christian-mueller/11/551/642 On Th

Re: Support of official commons-csv

2014-09-10 Thread Willem Jiang
When I upgraded the http client version of camel-http4 to 4.3.x, there were some API changes in http client just like common-csv. As we can do some adaption inside camel-http4, I just changed the configuration a bit.  I think we can do the same thing in camel-csv :) -- Willem Jiang Red Hat,

Re: Support of official commons-csv

2014-09-10 Thread Claus Ibsen
Hi Welcome back. I suspect the breakings is less affected by Camel users, eg I would assume the data it creates on the Camel Exchange / Message / body / headers can be the same as before? So the changes affected is maybe how to configure it using the csv data format or its csv config object? I a

Re: Support of official commons-csv

2014-09-10 Thread Charles Moulliard
Hi Antoine, For sure, if the integration of the new API with the old supported by camel dataformat will request a huge refactoring, this is logic to create a new dataformat for camel-csv2. Alternative is too deprecate what we support now but I don't think that this is a good idea. Regards, On

Support of official commons-csv

2014-09-10 Thread Antoine DESSAIGNE
Hi everyone, I was looking at this issue : https://issues.apache.org/jira/browse/CAMEL-7716. In fact, the commons-csv library changed a lot between the version that camel uses and the official one. In addition, there is lot of nice stuff such as: * immutable configurations, it's no longer require