Re: camel git commit: CAMEL-11609:thread-safety if headers get modified on the fly

2017-08-01 Thread Claus Ibsen
Hi I think there may be a checkstyle issues in this commit. On Tue, Aug 1, 2017 at 1:33 PM, wrote: > Repository: camel > Updated Branches: > refs/heads/master 3743c2256 -> 94f621d15 > > > CAMEL-11609:thread-safety if headers get modified on the fly > > > Project: http://git-wip-us.apache.org/

Re: camel git commit: CAMEL-11609:thread-safety if headers get modified on the fly

2017-07-28 Thread Onder SEZGIN
Hi, I say 0 for my commit :) Because it is currently not thread safe and sync will help to ensure it thread-safe modification of the list.. As discussed in the issue and PR as well, with this commit we can ensure thread-safety for the modification of the list We may discuss if this is a right ap

Re: camel git commit: CAMEL-11609:thread-safety if headers get modified on the fly

2017-07-28 Thread Claus Ibsen
Hi Yeah the data format implementation of marshal / unmarshal should be written in a thread-safe manner. So I think the current code in univocity may be wrong, if it has some kind of shared state for some headers. On Fri, Jul 28, 2017 at 10:51 AM, Zoran Regvart wrote: > Hi Cameleers, > > -1 >

Re: camel git commit: CAMEL-11609:thread-safety if headers get modified on the fly

2017-07-28 Thread Zoran Regvart
Hi Cameleers, -1 not sure that was the correct solution, perhaps `headers` field of Marshaller needs to be treated as immutable. Hard to tell on such a rarely used component what was the initial intent of `headers` field, but I guess it's what all marshallers need to add, so mutating it on a per