Github user adessaigne closed the pull request at:
https://github.com/apache/camel/pull/90
Keep 'em coming. We love contributions.
Backported to 2.12 branch as well.
On Wed, Feb 5, 2014 at 11:29 AM, Antoine DESSAIGNE
wrote:
> Thanks a lot for accepting this patch.
>
> Antoine
>
>
> 2014-02-05 Claus Ibsen :
>
>> Hi
>>
>> Yeah that makes sense to allow calling cancel(true) to interrupt a
Thanks a lot for accepting this patch.
Antoine
2014-02-05 Claus Ibsen :
> Hi
>
> Yeah that makes sense to allow calling cancel(true) to interrupt and
> do the forced shutdown.
> I added a code comment and revised the code.
>
>
> On Wed, Feb 5, 2014 at 8:20 AM, Antoine DESSAIGNE
> wrote:
> > Hi
Hi
Yeah that makes sense to allow calling cancel(true) to interrupt and
do the forced shutdown.
I added a code comment and revised the code.
On Wed, Feb 5, 2014 at 8:20 AM, Antoine DESSAIGNE
wrote:
> Hi,
>
> It was the point of this patch that the logic of the force shutdown was
> also executed
Hi,
It was the point of this patch that the logic of the force shutdown was
also executed when you cancel the future.
Consider a product that uses camel in order to deal with all its data
inputs and outputs, it has multiple CamelContext defined.
You can provide to the administrator the ability to
Polishing your patch as the timeout logic should only happen if a
timeout exception was thrown, as the original code.
Will commit the revised code in a bit. Is there a JIRA ticket?
On Mon, Feb 3, 2014 at 3:52 PM, Antoine DESSAIGNE
wrote:
> Hi,
>
> Do you have any concerns or suggestions about th
Hi,
Do you have any concerns or suggestions about these changes ? Right now,
I've copy/pasted the DefaultShutdownStrategy and added those changes on
order to make it work (and it's working nicely).
Also, if you don't like this public getter, we can also make it protected.
Thanks for the feedback
GitHub user adessaigne opened a pull request:
https://github.com/apache/camel/pull/90
Provide access to the shutdown task Future in order to have more control
over it
I'm submitting this patch in order to have a greater control over the
shutdown task.
It's very useful when inte