Comment inline > 在 2018年10月18日，下午1:49，shardul singh <shardulsing...@gmail.com> 写道： > > Hi, > 1. No it doesn't support UncompressShort/Int, Short/Int array needs to be > typecasted to byte array and then passed for compression.For uncompress we > get the result as byte array that need to be typecasted to Short/Int array > depending on requirement.
In PR2728, xuchuanyin modified the compress/uncompress interface to keep only compressByte, and modified the ColumnPage to use ByteArray instead of primitive data arrays, if this help you simplify the GZip PR, we should work on PR2728 and merge it. What do you think? > 2. No it doesn't need uncompressed size. > 3. Yes data copy is required during uncompression to avoid compressed data > getting modified. Also required if the offset of the data is not 0. Please check whether Gzip offers uncompression method that accept ByteBuffer, maybe we can move the position of the ByteBuffer and Gzip can uncompress start from the position we give? I remember ZSTD supports like this. > > Regards, > Shardul > > On Thu, Oct 18, 2018 at 9:09 AM Jacky Li <jacky.li...@qq.com> wrote: > >> +1 >> >> I have some question: >> 1. Other than uncompressByteArray, Does Gzip offers uncompressShortArray, >> uncompresssIntArray? >> 2. Does Gzip need uncompress size to allocate the target array before >> uncompressing? >> 3. Does you solution require data copy? >> >> Regards, >> Jacky >> >>> 在 2018年10月12日，下午6:49，shardul singh <shardulsing...@gmail.com> 写道： >>> >>> Hi community, >>> Currently carbon supports SNAPPY and ZSTD codec. Proposing to add Gzip as >>> the compression codec offered by carbon. >>> Some benefits of having Gzip compression codec are : >>> >>> 1. Gzip offers reduced file size compared to other codec like snappy >> but >>> at the cost of processing speed. >>> 2. Gzip is suitable for users who have cold data i.e. data which which >>> is stored permanently and will be queried rarely. >>> >>> I have created the jira issue for the same. >>> https://issues.apache.org/jira/browse/CARBONDATA-3005 and will add the >>> design document there. >>> Any suggestions regarding this are welcomed by the community. >>> >>> Regards, >>> Shardul >>> >> >> >> >> >
