RE: Proposal to integrate QATCodec into Carbondata

2018-11-01 Thread Xu, Cheng A
Hi Jacky The repo address is at https://github.com/intel-hadoop/IntelQATCodec open source with apache license. Regards to the hardware dependencies and its performance, it needs the extra QAT device [1] to have the hardware acceleration and will fall back to SW based GZip implementation. Its

Re: Proposal to integrate QATCodec into Carbondata

2018-11-01 Thread Jacky Li
Hi, Good to know about QATCodec. I have a quick question. Is the QATCodec an independent compression/decompression library or it depends on any hardware to achieve the performance improvement you have mentioned? Is there any link for QATCodec project or source code? Regards, Jacky > 在

RE: Proposal to integrate QATCodec into Carbondata

2018-11-01 Thread Xu, Cheng A
Thanks Raghu. Will prepare for the pull request. Thanks Ferdinand Xu -Original Message- From: Raghunandan S [mailto:carbondatacontributi...@gmail.com] Sent: Thursday, November 1, 2018 7:09 PM To: dev@carbondata.apache.org Subject: Re: Proposal to integrate QATCodec into Carbondata +1

Re: [Discussion] Refactor dynamic configuration

2018-11-01 Thread xubo245
ok, this is better: public static final Property CARBON_BAD_RECORDS_ACTION = Property.buildStringProperty(). .name(“carbon.bad.records.action”) .default(“FAIL”) .doc(“keep the same description as .md file”) .dynamic(true) .build() I will raise

Re: Proposal to integrate QATCodec into Carbondata

2018-11-01 Thread Raghunandan S
+1 This would further enhance the performance of queries where io is the bottleneck Regards Raghu On Fri, 12 Oct 2018, 12:18 pm Xu, Cheng A, wrote: > Thanks Chuanyin. This PR looks cool. Allowing customized codec is a good > option. Comparing with the existing built-in Snappy codec in

[Discussion] Do we need implement one reader read with different filter many times?

2018-11-01 Thread xubo245
Some users want to build one reader, and then read with different filter many times. But CarbonSDK only support add filter before build, then read with this filter, user can't change filter after build. Do we need implement one reader read with different filter many times? -- Sent from:

[Discussion] Add which test framework for C++ SDK?

2018-11-01 Thread xubo245
For C++ SDK of carbonData, we need add a test framework to manage test case, including unit test. So add which test framework for C++ SDK? we should discuss in here. I research before, find googletest is a popular test framework, we can try to use it. are there any other better test framework?

Re: [Discussion] Refactor dynamic configuration

2018-11-01 Thread xubo245
the annotation mainly providing literal explain whether this parameter can be dynamic configurable. What's more, it will throw exception if add @CarbonProperty and can't be dynamic configurable. If don't add @CarbonProperty for parameter, it won't throw exception and also won't take effect --