[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4315: URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501402247 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6384/ -- This is an automated message from the Apache Git Service. To r

Re: [Discussion] Improve better usability for CarbonData

2023-04-09 Thread Akash r
Hi xubo, +1 Thank you for suggesting this. Totally agree with it. Containerising carbon data is much needed one. Few inputs to consider 1. Since most of the users are not using spark 2.4 and spark 2.4 we have to put effort in removing the support. 2. We can support docker container for spark 3 o

[GitHub] [carbondata] shenjiayu17 commented on pull request #4314: [ISSUE-4313] Add @Override for override method of processing module

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4314: URL: https://github.com/apache/carbondata/pull/4314#issuecomment-1501352043 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/768/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4315: URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501285564 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/767/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4314: [ISSUE-4313] Add @Override for override method of processing module

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4314: URL: https://github.com/apache/carbondata/pull/4314#issuecomment-1501238082 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4676/ -- This is an automated message from the Apache Git Service.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4315: [ISSUE-4313] Variable should use LowerCamelCase style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4315: URL: https://github.com/apache/carbondata/pull/4315#issuecomment-1501223110 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4675/ -- This is an automated message from the Apache Git Service.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4314: [ISSUE-4313] Add @Override for override method of processing module

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4314: URL: https://github.com/apache/carbondata/pull/4314#issuecomment-1501207672 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6383/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4312: [ISSUE-4306] Fix the error of SDKS3SchemaReadExample

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4312: URL: https://github.com/apache/carbondata/pull/4312#issuecomment-1501193054 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6382/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4312: [ISSUE-4306] Fix the error of SDKS3SchemaReadExample

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4312: URL: https://github.com/apache/carbondata/pull/4312#issuecomment-1501191117 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/766/ -- This is an automated message from the Apache Git Service. To r

Re: [Discussion] Improve better usability for CarbonData

2023-04-09 Thread Bo Xu
Using docker to run code is a very popular development method for users. Apache spark docker image has more then 100 downloads, jupyter/all-spark-notebook docker images has more then 5000 downloads On 2023/04/09 18:35:44 徐波 wrote: > For newcomers of CarbonData, it's not very easy to bu

[GitHub] [carbondata] shenjiayu17 commented on pull request #4312: [ISSUE-4306] Fix the error of SDKS3SchemaReadExample

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4312: URL: https://github.com/apache/carbondata/pull/4312#issuecomment-1501189395 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4674/ -- This is an automated message from the Apache Git Service.

[Discussion] Improve better usability for CarbonData

2023-04-09 Thread Bo Xu
For newcomers of CarbonData, it's not very easy to build CarbonData environment and run CarbonData. So we should improve better usability for CarbonData. There are some directions, we can discuss: 1. Provide docker image of CarbonData, we can run carbondata very easily. refer to spark: https://hub.

[Discussion] Improve better usability for CarbonData

2023-04-09 Thread 徐波
For newcomers of CarbonData, it's not very easy to build CarbonData environment and run CarbonData. So we should improve better usability for CarbonData. There are some directions, we can discuss: 1. Provide docker image of CarbonData, we can run carbondata very easily. refer to spark: https://hub.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4309: Issue 4305 optimize the static metho call

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4309: URL: https://github.com/apache/carbondata/pull/4309#issuecomment-1501187457 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/765/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] xubo245 opened a new pull request, #4315: [ISSUE-4313] Variable should use LowerCamelCase style

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4315: URL: https://github.com/apache/carbondata/pull/4315 ### Why is this PR needed? There are some code smells in processing module For example 1.Didn't add @OverRide for override method 2.magic number 3.variable Should Use LowerCamelC

[GitHub] [carbondata] xubo245 opened a new pull request, #4314: [ISSUE-4313] Add @Override for override method of processing module

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4314: URL: https://github.com/apache/carbondata/pull/4314 ### Why is this PR needed? There are some code smells in processing module For example 1.Didn't add @OverRide for override method 2.magic number https://github.com/apache/carbond

[GitHub] [carbondata] shenjiayu17 commented on pull request #4311: [ISSUE-4305] Optimize the constants and variable style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4311: URL: https://github.com/apache/carbondata/pull/4311#issuecomment-1501166048 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/764/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] xubo245 opened a new pull request, #4312: [ISSUE-4306] Fix the error of SDKS3SchemaReadExample

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4312: URL: https://github.com/apache/carbondata/pull/4312 Fix the issue when read schema from S3 ### Why is this PR needed? There are some error when I run the SDKS3SchemaReadExample https://github.com/apache/carbondata/issues/4306

[GitHub] [carbondata] shenjiayu17 commented on pull request #4309: Issue 4305 optimize the static metho call

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4309: URL: https://github.com/apache/carbondata/pull/4309#issuecomment-1501143033 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4673/ -- This is an automated message from the Apache Git Service.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4311: [ISSUE-4305] Optimize the constants and variable style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4311: URL: https://github.com/apache/carbondata/pull/4311#issuecomment-1501124596 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4672/ -- This is an automated message from the Apache Git Service.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4309: Issue 4305 optimize the static metho call

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4309: URL: https://github.com/apache/carbondata/pull/4309#issuecomment-1501106703 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6381/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4311: [ISSUE-4305] Optimize the constants and variable style

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4311: URL: https://github.com/apache/carbondata/pull/4311#issuecomment-1501090829 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6380/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4308: [ISSUE-4305] Add @Override for override method

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4308: URL: https://github.com/apache/carbondata/pull/4308#issuecomment-1501074982 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/763/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4307: URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074932 Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/762/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4307: URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074867 Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4671/ -- This is an automated message from the Apache Git Service.

[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
shenjiayu17 commented on PR #4307: URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074813 Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6379/ -- This is an automated message from the Apache Git Service. To r

[GitHub] [carbondata] chenliang613 merged pull request #4308: [ISSUE-4305] Add @Override for override method

2023-04-09 Thread via GitHub
chenliang613 merged PR #4308: URL: https://github.com/apache/carbondata/pull/4308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@carbon

[GitHub] [carbondata] chenliang613 merged pull request #4310: [ISSUE-4305] Optimize the usage of equalsIgnoreCase, which can avoid NPE

2023-04-09 Thread via GitHub
chenliang613 merged PR #4310: URL: https://github.com/apache/carbondata/pull/4310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@carbon

[GitHub] [carbondata] chenliang613 commented on pull request #4310: [ISSUE-4305] Optimize the usage of equalsIgnoreCase, which can avoid NPE

2023-04-09 Thread via GitHub
chenliang613 commented on PR #4310: URL: https://github.com/apache/carbondata/pull/4310#issuecomment-1501064633 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [carbondata] chenliang613 merged pull request #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
chenliang613 merged PR #4307: URL: https://github.com/apache/carbondata/pull/4307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@carbon

[GitHub] [carbondata] chenliang613 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
chenliang613 commented on PR #4307: URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501064484 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [carbondata] xubo245 opened a new pull request, #4311: [ISSUE-4305] Optimize the constants and variable style

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4311: URL: https://github.com/apache/carbondata/pull/4311 ### Why is this PR needed? CONSTANTS should be like: UPPER_NAME; variable should be lowerCamelCase ### What changes were proposed in this PR? CONSTANTS should

[GitHub] [carbondata] xubo245 opened a new pull request, #4310: [ISSUE-4305] Optimize the usage of equalsIgnoreCase, which can avoid NPE

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4310: URL: https://github.com/apache/carbondata/pull/4310 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the chan

[GitHub] [carbondata] xubo245 opened a new pull request, #4309: Issue 4305 optimize the static metho call

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4309: URL: https://github.com/apache/carbondata/pull/4309 ### Why is this PR needed? static method shouldn't be called by object, it should be call by class ### What changes were proposed in this PR? Optimize the usage of static method

[GitHub] [carbondata] xubo245 opened a new pull request, #4308: [ISSUE-4305] Add @Override for override method

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4308: URL: https://github.com/apache/carbondata/pull/4308 ### Why is this PR needed? There are some code style, which should be optimized ### What changes were proposed in this PR? There are some code style, which should be optimized

[GitHub] [carbondata] xubo245 opened a new pull request, #4307: [ISSUE-4305] Optimize the magic number

2023-04-09 Thread via GitHub
xubo245 opened a new pull request, #4307: URL: https://github.com/apache/carbondata/pull/4307 ### Why is this PR needed? There are some code style, which should be optimized ### What changes were proposed in this PR? optimize the magic code in example ### Does th