I find the PR in github and leave a comment. Here I copy the comments:
I have doubt about the below scenario:
For sort_columns, the minmax is ordered for all the blocks/blocklets in one
segment.
Suppose that we are doing filtering on sort_columns and the filter looks
like Col1='bb'.
If the
+1
Better to clean it if it is not used
Regards,
Jacky
> 在 2018年8月24日，下午6:01，Kunal Kapoor 写道：
>
> +1 for removing unused code
>
>
>
> Regards
> Kunal Kapoor
>
>
> On Fri, Aug 24, 2018, 2:09 PM Ravindra Pesala wrote:
>
>> +1
>> We can remove unused code
>>
>> Regards,
>> Ravindra
>>
>>
+1 for removing unused code
Regards
Kunal Kapoor
On Fri, Aug 24, 2018, 2:09 PM Ravindra Pesala wrote:
> +1
> We can remove unused code
>
> Regards,
> Ravindra
>
> On Fri, 24 Aug 2018 at 14:06, Kumar Vishal
> wrote:
>
> > >
> > > +1
> >
> > Better to remove Btree code as now it is not
>
> +1
Better to remove Btree code as now it is not getting used.
-Regards
Kumar Vishal
+0 for 1. delete 11 files
Better to add Start/End keys to DataMapRow also.
In my opinion, the union of Min/Max values and Start/End keys can work
better.
-
Best Regards
David Cai
--
Sent from:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/
Hi All,
Since I read latest code of carbon and found that BTree related code is
only used by a test class called`BTreeBlockFinderTest`. So I try delete
those codes and test shows it works fine. But I wonder whether to delete
those code now or anyone thinks it can be used for something else ?
