Re: [Issue] Bloomfilter datamap

2018-09-25 Thread aaron
Based on that fix, drop existed table and data, re-creating the table and datamap is exactly as you said, no problem. But I did not delete the data and table yesterday, just create a new datamap, there will be some problems. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.11305

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread xuchuanyin
Did you use the query in the first post? I tested it and it's OK, we can see the bloomfilter while explaining. 1. If bloomfilter is not there, the reason may be that the main datamap has already pruned all the blocklets. In this case, the following index datamap will be skipped for shortcut. Often

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread aaron
But one more comment, it seems that bloomfilter datamap disappears from the query plan in detailed query? so what's the case which is for the bloomfilter? -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread aaron
Yes, you're right. The fix make master work now. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread xuchuanyin
You can download the patch and apply it to master, then you can rebuild the jar and perform testing. On Tue, Sep 25, 2018 at 5:02 PM +0800, "aaron" <949835...@qq.com> wrote: Great! thanks for your so quick response! I will have a try. Do you mean that I merge https://github.com/apac

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread aaron
Great! thanks for your so quick response! I will have a try. Do you mean that I merge https://github.com/apache/carbondata/pull/2665? Thanks aaron -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread xuchuanyin
More details about this issue. I've add some logs in `BloomCoarseGrainDataMap.createQueryModel` to print the input parameter 'expression'. # Before applying PR2665 ``` XU expression: org.apache.carbondata.core.scan.expression.logical.AndExpression@3b035d0c XU expression statement:(((category

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread xuchuanyin
Hi, arron. Actually your query will not use the time series datamap since the filter use filed 'product_id' which is not contained in your preagg datamap. Even I remove the preagg datamap, the query with bloomfilter datamap still failed with the same error logs as that in your post. Then I add som

Re: [Issue] Bloomfilter datamap

2018-09-25 Thread xuchuanyin
Yeah, I am able to reproduce this problem using current master code. I'll look into it. -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: [Issue] Bloomfilter datamap

2018-09-24 Thread aaron
I use 1.5.0-SNAPSHOT, but I'm not sure about 1.4.1 (I forget that I have test it or not) -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/

Re: [Issue] Bloomfilter datamap

2018-09-24 Thread xuchuanyin
hi, aaron, thanks for your feedback. Which version of carbondata are you using? -- Sent from: http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/