[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

2016-09-25 Thread Zhangshunyu
Github user Zhangshunyu commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80413220 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java --- @@ -17,13 +17,14 @@ package or

Re: [Discuss]Set block_size for table on table level

2016-09-25 Thread Ravindra Pesala
+1 At same time max and min block size should be restricted and validated while creating table. On 26 September 2016 at 07:36, Zhangshunyu wrote: > Purpose: > To configure block file size for each table on column level, so that each > table could has its own blocksize. > My solution: > Add a new

[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

2016-09-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80410923 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java --- @@ -17,13 +17,14 @@ package org.ap

[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

2016-09-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80411022 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java --- @@ -52,12 +56,27 @@ public static LoadStatist

[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

2016-09-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80410854 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonTimeStatisticsFactory.java --- @@ -17,13 +17,14 @@ package org.ap

[GitHub] incubator-carbondata pull request #176: [CARBONDATA-208] Add configuration e...

2016-09-25 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/176#discussion_r80411176 --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonDictionaryDecoder.scala --- @@ -158,7 +158,8 @@ case class CarbonDictiona

[Discuss]Set block_size for table on table level

2016-09-25 Thread Zhangshunyu
Purpose: To configure block file size for each table on column level, so that each table could has its own blocksize. My solution: Add a new parameter in table properties, when create a table, the user can set it in ddl. Add a parameter in thrift format just like other properties, and write this in