Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Josh McKenzie
> There's also tests that hardcode I started mentally twitching when I hit that point in the sentence. **Kill them with fire.** On Sun, Aug 13, 2023, at 4:51 PM, Mick Semb Wever wrote: >> >> https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/DirectoriesTest.java#L71

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Mick Semb Wever
> > > > https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/DirectoriesTest.java#L717-L719 > > https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/DirectoriesTest.java#L757-L759 > > Can I open a ticket to track fixes for these and any other

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Derek Chen-Becker
OK, I already found some places where "/tmp" is hard-coded: https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/DirectoriesTest.java#L717-L719 https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/DirectoriesTest.java#L757-L759 Can I open a

Re: [VOTE] Release Apache Cassandra 3.11.16

2023-08-13 Thread Brandon Williams
+1 Kind Regards, Brandon On Thu, Aug 10, 2023 at 1:43 AM Miklosovic, Stefan wrote: > > Proposing the test build of Cassandra 3.11.16 for release. > > sha1: f86929eae086aa108cf58ee0164c3d12a59ad4af > Git: https://github.com/apache/cassandra/tree/3.11.16-tentative > Maven Artifacts: > https://rep

Re: Tokenization and SAI query syntax

2023-08-13 Thread Caleb Rackliffe
We’ve already started down the path of using a git sub-module for the Accord library. That could be an option at some point. > On Aug 13, 2023, at 12:53 PM, Jon Haddad wrote: > > Functions make sense to me too. In addition to the reasons listed, I if we > acknowledge that functions in predic

Re: Tokenization and SAI query syntax

2023-08-13 Thread Jon Haddad
Functions make sense to me too. In addition to the reasons listed, I if we acknowledge that functions in predicates are inevitable, then it makes total sense to use them here. I think this is the most forward thinking approach. Assuming this happens, one thing that would be great down the line

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Josh McKenzie
> I think we want/need relative paths, e.g. "build/tmp", and if the path is in > a mounted volume there can be another container still running. Sure. The specifics of *what* path isn't interesting to me. The pattern of: 1. Let env declare where TEMP lives 2. Write things to TEMP 3. Delete things

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Derek Chen-Becker
Nevermind, I found "tmp.dir" On Sun, Aug 13, 2023 at 9:29 AM Derek Chen-Becker wrote: > Cool, > > I'm a little confused. Is "tmp.dir" a custom Java property that we expose? > I thought that the standard "property was "java.io.tmpdir". Let me take a > stab at setting tmp.dir to build/tmp and see

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Derek Chen-Becker
Cool, I'm a little confused. Is "tmp.dir" a custom Java property that we expose? I thought that the standard "property was "java.io.tmpdir". Let me take a stab at setting tmp.dir to build/tmp and see if I run into any issues (or still see any files in /tmp). Cheers, Derek On Sun, Aug 13, 2023 a

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Mick Semb Wever
On Sun, 13 Aug 2023 at 16:48, Josh McKenzie wrote: > Why not use "/${CASS_BUILD_TMP}/cassandra." on a given run and then > on subsequent runs "rm -rf f/${CASS_BUILD_TMP}/cassandra.*"? If > CASS_BUILD_TMP is not defined, default to /tmp. > I think we want/need relative paths, e.g. "build/tmp", a

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Josh McKenzie
Why not use "/${CASS_BUILD_TMP}/cassandra." on a given run and then on subsequent runs "rm -rf f/${CASS_BUILD_TMP}/cassandra.*"? If CASS_BUILD_TMP is not defined, default to /tmp. "ant clean" can also wipe it. If it's a safe assumption that we only ever need 1 instance of data in that space (i

Re: [Discuss] cleaning up build temp files

2023-08-13 Thread Mick Semb Wever
> While doing some local testing, I noticed that my /tmp drive completely > filled with test artifact files (e.g. data directories, logs, commit logs, > etc). Mick pointed out that we do attempt to do some "find" based cleanup > in CI ( > https://github.com/apache/cassandra-builds/blob/trunk/jenkin