Re: thrift generated java changes

2011-07-05 Thread Eric Evans
On Sat, 2011-07-02 at 22:29 -0400, Joseph Stein wrote: > right now I just manually put this function back in since it is the > only thing (well the license too of course) that the generation > changed from what is in source besides my change required. I wouldn't worry much about this. Do the bes

Re: thrift generated java changes

2011-07-02 Thread Joseph Stein
using 0.6.1 it went better, almost perfect the diff is still removing this code though and not sure why @Override public int hashCode() { -HashCodeBuilder builder = new HashCodeBuilder(); - -boolean present_name = true && (isSetName()); -builder.append(present_name); -if (pr

Re: thrift generated java changes

2011-07-02 Thread Jake Luciani
0.8 uses thrift 0.6 On Jul 2, 2011, at 11:40 AM, Joseph Stein wrote: > So I am working on https://issues.apache.org/jira/browse/CASSANDRA-2833 > > And when I generate the cassandra.thrift file I am getting weird results and > differences > > Should I be modifying the CounterColumn.java by h

thrift generated java changes

2011-07-02 Thread Joseph Stein
So I am working on https://issues.apache.org/jira/browse/CASSANDRA-2833 And when I generate the cassandra.thrift file I am getting weird results and differences Should I be modifying the CounterColumn.java by hand? I am using thrift 0.5.0 and doing thrift -gen java cassandra.thrift from the com