Re: [ANNOUNCE] Add nafiyaix(Xia Yifan) as new committer

2022-12-01 Thread wangsheng
Congratulations!!! Best Regards, Binjie Yang > 2022年12月2日 下午3:33,Cheng Pan 写道: > > Congrats, and thanks for your continuous work on Celeborn project. > > Thanks, > Cheng Pan > > > On Dec 2, 2022 at 14:09:49, angers zhu wrote: > >> Congratulations! >> >> Best Regards >> Anegrszh >> >

Re: [ANNOUNCE] Add nafiyaix(Xia Yifan) as new committer

2022-12-01 Thread Cheng Pan
Congrats, and thanks for your continuous work on Celeborn project. Thanks, Cheng Pan On Dec 2, 2022 at 14:09:49, angers zhu wrote: > Congratulations! > > Best Regards > Anegrszh > > Yu Li 于2022年12月2日周五 12:53写道: > > Congratulations and welcome, Yifan! > > > Best Regards, > > Yu > > > On We

[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1041: [CELEBORN-89][REFACTOR] MapperEnd should enable set separated timeout configuration

2022-12-01 Thread GitBox
AngersZh commented on PR #1041: URL: https://github.com/apache/incubator-celeborn/pull/1041#issuecomment-1334852156 I think we don't need to do change for MapperEnd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-celeborn] nafiyAix opened a new pull request, #1041: [CELEBORN-89][REFACTOR] MapperEnd should enable set separated timeout configuration

2022-12-01 Thread GitBox
nafiyAix opened a new pull request, #1041: URL: https://github.com/apache/incubator-celeborn/pull/1041 ### What changes were proposed in this pull request? MapperEnd should enable set separated timeout configuration ### Why are the changes needed? Previously MapperEnd requests fr

Re: [ANNOUNCE] Add nafiyaix(Xia Yifan) as new committer

2022-12-01 Thread angers zhu
Congratulations! Best Regards Anegrszh Yu Li 于2022年12月2日周五 12:53写道: > Congratulations and welcome, Yifan! > > Best Regards, > Yu > > On Wed, Nov 30, 2022 at 11:25 PM Keyong Zhou wrote: > > > Hi celeborn(-incubating) community, > > > > I'm very excited to announce that recently we added naf

[GitHub] [incubator-celeborn] FMX commented on pull request #1026: [CELEBORN-81] Add codecov.

2022-12-01 Thread GitBox
FMX commented on PR #1026: URL: https://github.com/apache/incubator-celeborn/pull/1026#issuecomment-1334804919 According the INFRA ticket comments, I think the codecov is configured and usable. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-celeborn] FMX merged pull request #1039: [CELEBORN-96][REFACTOR] PushMergedData return partition not found use same code path

2022-12-01 Thread GitBox
FMX merged PR #1039: URL: https://github.com/apache/incubator-celeborn/pull/1039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celebor

[GitHub] [incubator-celeborn] FMX opened a new pull request, #1040: [CELEBORN-97] Correct notification mailing list.

2022-12-01 Thread GitBox
FMX opened a new pull request, #1040: URL: https://github.com/apache/incubator-celeborn/pull/1040 # [CELEBORN-97] Correct notification mailing list. ### What changes were proposed in this pull request? ### Why are the changes needed? To eliminate the error message.

Re: [ANNOUNCE] Add nafiyaix(Xia Yifan) as new committer

2022-12-01 Thread Yu Li
Congratulations and welcome, Yifan! Best Regards, Yu On Wed, Nov 30, 2022 at 11:25 PM Keyong Zhou wrote: > Hi celeborn(-incubating) community, > > I'm very excited to announce that recently we added nafiyaix(Xia Yifan) as > our new Committer! > > nafiyaix has kept contributing to celeborn for m

[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1039: [CELEBORN-96][REFACTOR] PushMergedData return partition not found use same code path

2022-12-01 Thread GitBox
AngersZh commented on PR #1039: URL: https://github.com/apache/incubator-celeborn/pull/1039#issuecomment-1334719740 @FMX @waitinfuture -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1039: [CELEBORN-96][REFACTOR] PushMergedData return partition not found use same code path

2022-12-01 Thread GitBox
AngersZh opened a new pull request, #1039: URL: https://github.com/apache/incubator-celeborn/pull/1039 ### What changes were proposed in this pull request? ### Why are the changes needed? ### What are the items that need reviewer attention? ### Related

[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1003: [CELEBORN-56] [ISSUE-945] handle map partition mapper end

2022-12-01 Thread GitBox
RexXiong commented on code in PR #1003: URL: https://github.com/apache/incubator-celeborn/pull/1003#discussion_r1037156128 ## client/src/main/java/org/apache/celeborn/client/ShuffleClient.java: ## @@ -147,11 +147,21 @@ public abstract int mergeData( public abstract void push

[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1031: [CELEBORN-86][REFATCOR] Register shuffle should have separated timeout configuration

2022-12-01 Thread GitBox
AngersZh merged PR #1031: URL: https://github.com/apache/incubator-celeborn/pull/1031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr..

[GitHub] [incubator-celeborn] FMX commented on pull request #1026: [CELEBORN-81] Add codecov.

2022-12-01 Thread GitBox
FMX commented on PR #1026: URL: https://github.com/apache/incubator-celeborn/pull/1026#issuecomment-1333546805 It works without token but unstable. So I think this pr can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1031: [CELEBORN-86][REFATCOR] Register shuffle should have separated timeout configuration

2022-12-01 Thread GitBox
AngersZh commented on code in PR #1031: URL: https://github.com/apache/incubator-celeborn/pull/1031#discussion_r1036929355 ## client/src/test/java/org/apache/celeborn/client/ShuffleClientSuiteJ.java: ## @@ -182,13 +179,13 @@ private CelebornConf setupEnv(CompressionCodec co

[GitHub] [incubator-celeborn] FMX commented on pull request #1026: [CELEBORN-81] Add codecov.

2022-12-01 Thread GitBox
FMX commented on PR #1026: URL: https://github.com/apache/incubator-celeborn/pull/1026#issuecomment-1333501509 Waiting for the Jira ticket https://issues.apache.org/jira/browse/INFRA-23972?orderby=cf%5B12313920%5D+ASC%2C+priority+DESC%2C+updated+DESC -- This is an automated message f

[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1025: [CELEBORN-80] FileWriter supports MapPartition

2022-12-01 Thread GitBox
RexXiong commented on code in PR #1025: URL: https://github.com/apache/incubator-celeborn/pull/1025#discussion_r1036810882 ## worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/FileWriter.java: ## @@ -189,12 +234,19 @@ public void write(ByteBuf data) throws

[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1025: [CELEBORN-80] FileWriter supports MapPartition

2022-12-01 Thread GitBox
RexXiong commented on code in PR #1025: URL: https://github.com/apache/incubator-celeborn/pull/1025#discussion_r1036810067 ## worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/FileWriter.java: ## @@ -119,6 +162,8 @@ public FileWriter( this.mapIdBitMa