+1 (non-binding)
I checked the following things:
- git commit hash is correct.
- download links are valid.
- release files are in correct location.
- release files have the word incubating in their name.
- signatures and checksums are good.
- DISCLAIMER, LICENSE and NOTICE files exist.
- build succ
+1 (non-binding)
I checked the following things:
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.3.2-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.3.2-incubating-bin.tgz.asc
```
- checksums are good.
```
sha512sum --check apache-celeborn-0.3.2-incubating-sou
+1
I checked
- download links are valid.
- git commit hash is correct.
- no binary files in the source release.
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.3.2-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.3.2-incubating-bin.tgz.asc
```
- checksums are go
+1 (binding)
I checked
- Download links are valid.
- git commit hash is correct
- Checksums and signatures are valid.
- No binary files in the source release
- Files have the word incubating in their name.
- DISCLAIMER,LICENSE and NOTICE files exist.
- Successfully built the binary from the source
+1 (binding)
I checked
- git commit hash is correct.
- links are valid.
- "incubating" is in the name.
- PGP keys are good.
- hashes are correct.
- LICENSE looks good.
- NOTICE looks good.
- DISCLAIMER exists.
- build success from source code (macOS). ``` ./build/make-distribution.sh
--release ```
+1
Signatures, digests, license, etc check out fine.
Checked out tag and build/tested with -Pspark3.1 and -Pflink-1.17
Regards,
Mridul
On Tue, Dec 19, 2023 at 8:06 PM rexxiong wrote:
> +1 (binding)
> I checked
> - Download links are valid.
> - git commit hash is correct
> - Checksums and sign
+1
- Checked all links are valid
- GitHub CI result is good
Thanks,
Cheng Pan
> On Dec 20, 2023, at 10:38, Mridul Muralidharan wrote:
>
> +1
>
> Signatures, digests, license, etc check out fine.
> Checked out tag and build/tested with -Pspark3.1 and -Pflink-1.17
>
> Regards,
> Mridul
>
>
>
+1
- Checked build with all version spark
Thanks Angerszh
Cheng Pan 于2023年12月20日周三 10:48写道:
> +1
>
> - Checked all links are valid
> - GitHub CI result is good
>
> Thanks,
> Cheng Pan
>
> > On Dec 20, 2023, at 10:38, Mridul Muralidharan wrote:
> >
> > +1
> >
> > Signatures, digests, licen