+1 (binding)
I checked
- git commit hash is correct.
- links are valid.
- "incubating" is in the name.
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
```
- checksums are good.
```
s
+1 (non-binding)
I checked the following things:
- git commit hash is correct.
- download links are valid.
- release files are in correct location.
- release files have the word incubating in their name.
- signatures and checksums are good.
- DISCLAIMER, LICENSE and NOTICE files exist.
- build succ
+1(binding)
I checked:
√ release files in the correct location
√ release files have the word incubating
√ digital signature and hashes correct
√ DISCLAIMER file exist
√ LICENSE and NOTICE files exist and are correct
√ the contents of the release match the tag in VCS
√ can build the release from th
+1 binding
I checked
- links are valid
- build success from source (CentOS 7, x86, OpenJDK 8)
- LICENSE and NOTICE look good
- DISCLAIMER exist
- incubating present in artifacts name
Thanks,
Cheng Pan
> On Jan 19, 2024, at 15:29, Ethan Feng wrote:
>
> +1(binding)
>
> I checked:
> √ release
+1 (binding)
I checked
- Download links are valid.
- git commit hash is correct
- Checksums and signatures are valid.
- No binary files in the source release
- Files have the word incubating in their name.
- DISCLAIMER,LICENSE and NOTICE files exist.
- Successfully built the binary from the source
+1 (binding)
I checked
- Download links are valid
- git commit hash is correct
- Checksums and signatures are valid
- Release files have the word 'incubating' in their names
- DISCLAIMER, LICENSE and NOTICE files in tarballs are correct
- Successfully built the binary from the source on Linux usin
+1 (non-binding)
I have verified:
- Git commit hash is correct.
- Checksums and signatures are valid.
- Download links are valid.
- No binary files in the source release.
- Built the binary from the source with command successfully:
./build/make-distribution.sh -Pspark-3.1,flink-1.17. Regards,
N
+1 (non-binding)
I checked the following things:
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
```
- checksums are good.
```
sha512sum --check apache-celeborn-0.4.0-incubating-sou
-1 (binding)
- Checked the diff between 0.3.2 and 0.4.0-rc4: FAILED (
https://github.com/apache/incubator-celeborn/compare/v0.3.2-incubating...v0.4.0-incubating-rc4).
Problems observed include:
* The client-flink/flink-1.15-shaded module bundles
*com.google.guava:failureaccess* but has no entry
