Re: svn commit: r1628887 - in /celix/trunk/remote_services/remote_service_admin_http/private: include/remote_service_admin_http_impl.h src/remote_service_admin_impl.c

2014-10-01 Thread Bjoern Petri
On 2014-10-02 08:33, Alexander Broekhuis wrote: Looking at the commit, I do have some remarks on the code. The for loop for getting the address does not break if it finds a match. So if no interface is given, it will use the last one found, instead of the first one. And if a interface is give

Re: svn commit: r1628887 - in /celix/trunk/remote_services/remote_service_admin_http/private: include/remote_service_admin_http_impl.h src/remote_service_admin_impl.c

2014-10-01 Thread Alexander Broekhuis
Looking at the commit, I do have some remarks on the code. The for loop for getting the address does not break if it finds a match. So if no interface is given, it will use the last one found, instead of the first one. And if a interface is given, it will continue checking the others, even if a ma

Re: [jira] [Created] (CELIX-160) ip adress in service url is fixed

2014-10-01 Thread Alexander Broekhuis
2014-10-02 7:30 GMT+02:00 Bjoern Petri : > > Hi Alexander, > > I just committed some code which allows us to specify the IP-Address > directly or alternatively the name of the interface that should be used for > retrieving the IP-Address. If none is given, than the committed code > iterates over t

Re: [jira] [Created] (CELIX-160) ip adress in service url is fixed

2014-10-01 Thread Bjoern Petri
Hi Alexander, I just committed some code which allows us to specify the IP-Address directly or alternatively the name of the interface that should be used for retrieving the IP-Address. If none is given, than the committed code iterates over the found interfaces using the first IP-Address it

Re: [jira] [Created] (CELIX-160) ip adress in service url is fixed

2014-10-01 Thread Alexander Broekhuis
If you have a chance, and are working on this, the APR code can be removed. Perhaps it is even better to use it only via a property. The APR method looks at the hostname to find the address, if the system's hostname is not in the hosts file, it won't work. 2014-10-01 17:06 GMT+02:00 Bjoern Petri (

Re: [jira] [Updated] (CELIX-154) echo exampe not working

2014-10-01 Thread Alexander Broekhuis
I've created an issue for this at [1]. I will also look into what is needed for CLang. [1]: https://issues.apache.org/jira/browse/CELIX-159 2014-09-29 20:48 GMT+02:00 erjan altena : > Nice to see that the patch is merged so soon. > > The -pthread on linux is similar to "-lpthread -D_REENTRANT".